From: Shlomy R. <sre...@gm...> - 2009-08-23 17:53:40
|
In your previous email, you wrote that you tried the ConfigurableFoldHandler, and jEdit hung when you tried to collapse all folds. I took some large xml file and profile this operation with the ConfigurationFoldHandler (the folding mode named "custom"), and found out that more than 80% (I don't remember the exact percentage) of the time was spent on retrieving jEdit property values during the calculation of the fold level of each line (in ConfigurableFoldHandler). I fixed this performance bug (there is only a need to do it once for each buffer, at least until the properties change), and this operation became about 5x faster. I did not profile it with SideKick, nor did I make any changes to SideKick or the core for this matter. If you use the fixed ConfigurableFoldHandler, you will surely find a huge increase in performance of "collapse all". It might still hang for a while, after all I didn't make 1000x faster, only about 5x faster. Shlomy On Sun, Aug 23, 2009 at 7:23 PM, Mike Maxwell<ma...@um...> wrote: > Shlomy Reinstein wrote: >> >> A fix has been committed to SVN. For those who can't build and are >> interested in the fixed version, you can download it here: >> http://community.jedit.org/?q=node/view/4252 >> >> Please let me know if this fix does not work for you. > > No, it still hangs for a long time in my large XML file--not when I'm > folding (I haven't been able to try that), but when just displaying the > potential folds using Utilities | Global Options, Editing | Folding mode = > Sidekick. It appears that Sidekick is calculating the folds in the file > from top to bottom, and only when needed; and it can take a long time. That > means that if I open a file (or re-start jEdit with an already open file, > using the Sessions plugin), it's fine. But if I start to scroll down, or > drag the elevator scroll button down, or (I think) re-start jEdit with an > XML file where my saved position was far down the file, jEdit stops > responding for a long time. How long depends on how big the XML file is (I > haven't tried it on other kinds of files, but I wouldn't normally have a > 100k line file of Python :-).) > > The file where this really shows up is a proprietary file. However, I could > probably create a version of it with all the data replaced by Xs, if that > would help. It's about 25 megs, so I would need an ftp site to upload it > to. Or maybe I could just remove all the data, leaving the empty XML tags; > that might have the same effect, I haven't tried. Let me know if you need > that. > -- > Mike Maxwell > What good is a universe without somebody around to look at it? > --Robert Dicke, Princeton physicist > |