Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-2809686 ] tell build.xml to properly use build.properties
|
From: SourceForge.net <no...@so...> - 2009-07-13 02:20:31
|
Patches item #2809686, was opened at 2009-06-21 05:11 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2809686&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: general Group: None >Status: Closed Resolution: Invalid Priority: 5 Private: No Submitted By: Kevin Hunter (hunteke) Assigned to: Nobody/Anonymous (nobody) Summary: tell build.xml to properly use build.properties Initial Comment: While doing some fiddling, I noted that build.xml does not use build.properties where it could and should. This patch corrects that by updating build.properties.sample build.xml Also, since build.xml was previously hard-coding things like the "build" and "dist" directories, I uncommented those in build.properties.sample ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2009-07-13 02:20 Message: This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2009-06-28 13:33 Message: I agree with k_satoda about not removing the lines from build.xml. Default values should be set in the build.xml file, so there is no need to remove them. The build.properties file should be used to override the defaults. Whether the lines in the build.properties.sample file are commented or uncommented makes no difference, since that file is never loaded anyway. I like the addition of setting a property for "debug" for javac. It should have a default value of "true" defined in build.xml. ---------------------------------------------------------------------- Comment By: Kazutoshi Satoda (k_satoda) Date: 2009-06-28 10:53 Message: While I'm not the author of build.xml and not familier with ant, but I think build.properties should be completely optional. So uncommenting in build.properties.sample looks strange. And reading a pieace of manual... http://ant.apache.org/manual/CoreTasks/property.html > Properties are immutable: whoever sets a property first freezes it for > the rest of the build; they are most definitely not variables. It seems that the part the patch removes does provide a default which can be configured by build.properties. This patch seems invalid. However, updating comments and organization to express the fact like above more clearly may be good. ---------------------------------------------------------------------- Comment By: Kevin Hunter (hunteke) Date: 2009-06-21 05:23 Message: Whoops, wrong selection of category. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2809686&group_id=588 |