Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-2567351 ] make default more visible
|
From: SourceForge.net <no...@so...> - 2009-02-05 23:17:17
|
Patches item #2567351, was opened at 2009-02-05 10:17 Message generated for change (Comment added) made by shlomy You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2567351&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: texteditor Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Kevin Hunter (hunteke) Assigned to: Nobody/Anonymous (nobody) Summary: make default more visible Initial Comment: Currently, the highlight in HyperSearchResult defaults to a black color, which is barely noticeable next to the not-quite black text. Update the default to also bold the matching pattern. ---------------------------------------------------------------------- >Comment By: Shlomy Reinstein (shlomy) Date: 2009-02-06 01:17 Message: A small clarification: The reason why you had the prop = false is that you were using an earlier version (which existed only for 1 or 2 days in SVN) in which I used this property as a boolean. Since you had this temporary version of jEdit, it was registered in your properties file as a boolean, and this is actually the very reason why I added this try/catch block. For those who never had this temporary SVN version, there is no need for that. ---------------------------------------------------------------------- Comment By: Kevin Hunter (hunteke) Date: 2009-02-06 01:02 Message: Noted, but with the current HIGHLIGHT_PROP = "hypersearch.results.highlight", the HighlightingTree constructor was getting a prop = false, not null. This made the try/catch always take the catch branch in parseHighlightStyle. The default jEdit HyperSearchResults code currently *does* highlight with color:#000000 from that catch branch. But you can hardly see it because the rest of the text is off-black. I suggest that the default highlight is already #000000 from that catch branch. ---------------------------------------------------------------------- Comment By: Shlomy Reinstein (shlomy) Date: 2009-02-05 21:05 Message: The default highlight is none :-) This means that unless you pick some highlight style, there will be no highlighting. This is backward-compatible with the previous jEdit version, which did not support highlighting. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2567351&group_id=588 |