From: Kazutoshi S. <k_s...@f2...> - 2008-05-30 23:48:31
|
kp...@us... wrote: > Revision: 12725 > http://jedit.svn.sourceforge.net/jedit/?rev=12725&view=rev > Author: kpouer > Date: 2008-05-29 13:20:30 -0700 (Thu, 29 May 2008) > > Log Message: > ----------- > new bufferSet api Some comments which all are not related the new feature. Could you please separate the changes by "remove trailing whitespace" into another revision? It is hard to review the diff when they are mixed with the actual changes. > Modified: jEdit/trunk/org/gjt/sp/jedit/jEdit.java > =================================================================== (snip) > +// if(hasUntitledCleanBuffer()) > +// { (snip) > +// } Kill the code if it is no longer necessary, or put it out of comment if it should be there, or add another comment why it can't be decided. Otherwise, it will be kept as comment forever, possibly being not in sync with the code around. > Modified: jEdit/trunk/org/gjt/sp/jedit/jedit_gui.props > =================================================================== (snip) > - Bj\xF6rn "Vampire" Kautler\n\ > + Bj�rn "Vampire" Kautler\n\ Please, please, please look the diff before you do commit. Never repeat this again. -- k_satoda |