From: SourceForge.net <no...@so...> - 2008-05-04 11:57:06
|
Patches item #1797780, was opened at 2007-09-19 13:09 Message generated for change (Comment added) made by scarlac You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1797780&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: general Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nilo J. Gonzalez (nilojg) Assigned to: Seph M. Soliman (scarlac) Summary: New splashscreen with transparency and blur Initial Comment: I've done a new org.gjt.sp.jedit.gui.SplashScreen.java class. The old class paints an opaque png and the user sees a rectangular image. The new class paints a png with transparency, so the user sees an image with any shape. And the new class blurs the background too. The patch has a class (org.gjt.sp.jedit.gui.SplashScreen.java) and four images (the splashscreen, a mask to define the blured zone, the progressbar background and the progressbar foreground). How does it works? - The class loads the images - The class takes an screen capture with the width and height of the splash.png image. - Blurs the captured image area which is black in the splashMask.png. - Paints the blured captured image. - Paints the splash.png image. - Paints the splashProgressBackgroud.png - Paints the portion of the splashProgressForegroud.png If splash.png has transparent parts, user will see the background, and if that transparent parts are painted in the mask, the user will see that parts transparents and blured. I send four images for testing, but I'm sure a photoshop guru can do it better! PD: Sorry for my english... ---------------------------------------------------------------------- >Comment By: Seph M. Soliman (scarlac) Date: 2008-05-04 13:57 Message: Logged In: YES user_id=831311 Originator: NO What's the status of on this issue? Any splash screen should be very lightweight. The purpose for a splash screen is to tell the user that something is happening quickly so they don't become impatient. Some splash screens even incorporate a "tip of the day" to keep the user interested. I'd like it if we keep any splash screen code to a minimum of effects. With both Vista, Mac OS X and Ubuntu enabling shadow (and fade-in) effects to windows per default I think we should leave it to the OS to paint these effects. Regards, Seph ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2008-02-28 10:18 Message: Logged In: YES user_id=285591 Originator: NO The job that was done for 4.3pre13 was making the scrolling smoother, nothing related with this patch. This patch cannot be applied because it doesn't follow the coding rules of jEdit about braces, tabulations ... And also before applying that, I think we have to discuss about it, if everybody likes it ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2008-02-28 10:13 Message: Logged In: YES user_id=285591 Originator: NO The job that was done for 4.3pre13 was making the scrolling smoother, nothing related with this patch. This patch cannot be applied because it doesn't follow the coding rules of jEdit about braces, tabulations ... And also before applying that, I think we have to discuss about it, if everybody likes it ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2008-02-25 00:50 Message: Logged In: YES user_id=935841 Originator: NO What is the status of this patch, matthieu? I see that the splashscreen has been redone in pre13. Was that independent of this patch? ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2008-02-25 00:49 Message: Logged In: YES user_id=935841 Originator: NO What is the status of this patch, matthieu? I see that the splashscreen has been redone in pre13. Was that independent of this patch? ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2007-09-19 15:37 Message: Logged In: YES user_id=285591 Originator: NO Hi, sorry for what I said about 1.5, you're right. I don't know why but when I tried the first time with 1.5 there was no transparency and the splashscreen background was white. But now it works with 1.5 and 1.6. For the coding rules, there is no document that describes them, but you can take the previous code as example ---------------------------------------------------------------------- Comment By: Nilo J. Gonzalez (nilojg) Date: 2007-09-19 15:13 Message: Logged In: YES user_id=1377186 Originator: YES Where are the coding rules? It works in java 1.5, although is faster with java 1.6 ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2007-09-19 15:01 Message: Logged In: YES user_id=285591 Originator: NO Hi, when I spoke about keeping things at their places, I meant keeping fields at the end of the file, not moving them in the beginning for example. For committing, as I said, never, only a project admin can do that after the patch has been approved ---------------------------------------------------------------------- Comment By: Nilo J. Gonzalez (nilojg) Date: 2007-09-19 14:55 Message: Logged In: YES user_id=1377186 Originator: YES Images are in the org\gjt\sp\jedit\icons directory and the classes are in their places. When will I commit the changes to SVN? Which is the procedure? ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2007-09-19 14:44 Message: Logged In: YES user_id=285591 Originator: NO Oh and I just saw a big problem : it doesn't work with java 1.5 ... ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2007-09-19 14:41 Message: Logged In: YES user_id=285591 Originator: NO Hi, only the project admins are allowed to commit in the core. I tried your patch, it seems nice to me but I think the other developpers should agree before applying this patch. And there is a little problem with your code : you reformatted all the Splashscreen code, but it would be easier if you could keep things at the same place, for example not moving the fields on the top of the class. And please respect the coding rules about braces, and using tabs instead of spaces Matthieu ---------------------------------------------------------------------- Comment By: Nilo J. Gonzalez (nilojg) Date: 2007-09-19 13:15 Message: Logged In: YES user_id=1377186 Originator: YES Images are in the org\gjt\sp\jedit\icons directory and the classes are in their places. When will I commit the changes to SVN? Which is the procedure? ---------------------------------------------------------------------- Comment By: Nilo J. Gonzalez (nilojg) Date: 2007-09-19 13:13 Message: Logged In: YES user_id=1377186 Originator: YES File Added: splashProgressForegroud.png ---------------------------------------------------------------------- Comment By: Nilo J. Gonzalez (nilojg) Date: 2007-09-19 13:12 Message: Logged In: YES user_id=1377186 Originator: YES File Added: splashProgressBackgroud.png ---------------------------------------------------------------------- Comment By: Nilo J. Gonzalez (nilojg) Date: 2007-09-19 13:12 Message: Logged In: YES user_id=1377186 Originator: YES File Added: splashMask.png ---------------------------------------------------------------------- Comment By: Nilo J. Gonzalez (nilojg) Date: 2007-09-19 13:11 Message: Logged In: YES user_id=1377186 Originator: YES File Added: splash.png ---------------------------------------------------------------------- Comment By: Nilo J. Gonzalez (nilojg) Date: 2007-09-19 13:11 Message: Logged In: YES user_id=1377186 Originator: YES File Added: GUIUtilities.java ---------------------------------------------------------------------- Comment By: Nilo J. Gonzalez (nilojg) Date: 2007-09-19 13:10 Message: Logged In: YES user_id=1377186 Originator: YES File Added: SplashScreen.java ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1797780&group_id=588 |