From: SourceForge.net <no...@so...> - 2007-08-08 00:27:30
|
Plugin Bugs item #1755930, was opened at 2007-07-18 00:50 Message generated for change (Comment added) made by ezust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1755930&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Matthieu Casanova (kpouer) Assigned to: Dale Anson (daleanson) Summary: JavaSidekick 2.3.5 doesn't show errors Initial Comment: Hi, when I have parse error, Javasidekick never shows error in ErrorList, sometimes there is an exception in the activity log, and other time it says nothing like if my java file is perfect (but it's not) ---------------------------------------------------------------------- >Comment By: Alan Ezust (ezust) Date: 2007-08-07 17:27 Message: Logged In: YES user_id=935841 Originator: NO It looks like your latest commit disables error list error handling if you have completion enabled. I just committed a change that removes your check. Now I can see errors again. ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-08-06 22:06 Message: Logged In: YES user_id=187628 Originator: NO It works well for me. In the SideKick options, I've got all 3 of the checkboxes under "Auto Parse Settings" checked, under "Code Completion Options", I don't have either of the checkboxes checked. I've got the "After last keystroke, wait" set to about .75 seconds. Parsing won't happen if the file isn't a .java or .jj file, that is, it has to have been saved at least once. This is true even if you hit the parse button on an Untitled buffer, since there is no way to tell if the parse is occurring because of the button or because the text changed. I set it this way because I've got my default edit mode set to "java", and if I paste in a bunch of random, non-java text into a new buffer, I didn't want the parser spewing tons of error messages. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-08-06 20:28 Message: Logged In: YES user_id=935841 Originator: NO reopening this bug, It's not fixed yet, as far as I can tell... ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-08-05 07:41 Message: Logged In: YES user_id=187628 Originator: NO Okay, I think I have this fixed the way you're describing. Automatic parsing will not happen if auto-complete is on, but otherwise will happen as expected, I think. Please give it a test run and let me know. ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-08-03 06:27 Message: Logged In: YES user_id=187628 Originator: NO Is it the sidekick.complete-delay.toggle property that determines whether auto-complete is on? ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-08-02 23:01 Message: Logged In: YES user_id=935841 Originator: NO First, I think "Show Parse Errors In ErrorList" option should be the default, true. Second, I don't have auto-parse with delay at all, I just clicked the "parse" button on sidekick to get a parse while the buffer is dirty. I imagine that this cascade of errors from autocomplete mentioned in the comments could be caused by a auto parse with delay option, and if so, you should be checking if that option is on, rather than whether the buffer is dirty, since the parse can be initiated manually too. ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-08-02 21:33 Message: Logged In: YES user_id=187628 Originator: NO I suppose this is the cause of what you're talking about: if ( !buffer.isDirty() && errorSource != null ) { /* only handle errors when buffer is saved. Otherwise, there will be a lot of spurious errors shown when code completion is on and the user is in the middle of typing something. */ handleErrors( errorSource, parser, buffer ); Is it the sidekick.complete-delay.toggle property that determines whether auto-complete is on? ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-08-02 21:12 Message: Logged In: YES user_id=187628 Originator: NO Your sidekick settings would be useful too, in particular, which boxes you've got checked under the auto-parse settings. Thanks, Dale ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-08-02 21:11 Message: Logged In: YES user_id=187628 Originator: NO Would one of you attach an example file so I can see what you're talking about? It would also be useful if you could attach the part of your jEdit properties file with the javasidekick and jbrowse properties. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-08-02 10:03 Message: Logged In: YES user_id=935841 Originator: NO yes, I see that too. and this is specific to javasidekick because I don't see this from XML either. ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2007-08-01 23:50 Message: Logged In: YES user_id=285591 Originator: YES I think there is something else. You're right about the fact that the file must be saved as java file and I see now errors. But with a java file, if I create a parse error and reparse, the sidekick tree is broken (as expected) but no parse error is visible. I have to save it again. It looks like the parse errors aren't shown on dirty buffer too ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-08-01 21:28 Message: Logged In: YES user_id=187628 Originator: NO Ah, got it. If I just paste in the example in an untitled buffer and parse it with the java sidekick, there are no errors shown. If I save the buffer with a filename that has a .java extension, then I get the same messages that Alan reports. Looking at the code, I see I added a comment that says to only show errors for files with a .java extension because I thought it was annoying otherwise. Alan, you're right, it's time for a release, I'll get one together and submit it. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-08-01 19:00 Message: Logged In: YES user_id=935841 Originator: NO In 2.3.4 it is not fixed, but in the SVN version (2.3.5), I can cut and paste that very same example and I see 2 errors reported: Parse Error at line 4, column 1. Encountered: <EOF> Parse Error at line 4, column 1. Encountered: } ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-08-01 18:17 Message: Logged In: YES user_id=187628 Originator: NO I guess I should ask for clarification -- Matthieu, do you ever see any errors reported? That is, do you see them for most files, but not necessarily for all files? I see errors on files most of the time (heh... sounds like I write a lot of bad code!), but hadn't noticed errors not being reported until you posted this bug. ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-08-01 18:10 Message: Logged In: YES user_id=187628 Originator: NO It's not fixed. Try pasting in the example that Matthieu posted below: public class Test { a } into a new buffer. It parses without error, but it shouldn't. I haven't spent any time on this one yet, but hope to get to it fairly soon. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-08-01 11:57 Message: Logged In: YES user_id=935841 Originator: NO This bug was fixed in 2.3.5 (svn) but it was not released yet. Dale? time to post a release announcement? ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-08-01 11:44 Message: Logged In: YES user_id=935841 Originator: NO I am able to get errors from JavaSideKick. linux, jdk1.6 and 1.5, javasidekick 2.3.5. Is your problem under windows only? ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2007-07-18 06:29 Message: Logged In: YES user_id=285591 Originator: YES It is checked. For example with that class public class Test { a } no exception and no parse error in error list ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-07-18 06:18 Message: Logged In: YES user_id=187628 Originator: NO Could it be that you don't have the "Show parse errors in ErrorList" checkbox checked in the JavaSideKick options? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1755930&group_id=588 |