Re: [ jEdit-devel ] Fwd: DockableWindowManager questions

[Shlomy R. <sre...@gm...>]

I didn't suggest fixing jEdit like you mentioned because:
1. I don't know if the view closed message is not sent for the last view on
purpose of if it's a bug.
2. I don't know if that's the best way to do it. Maybe it's better to send a
message each time a dockable window is closing (for whatever reason)?

Anyway:
- If we want to be able to use my flexdock plugin to provide enhanced
docking capabilities in jEdit, we need to have this issue resolved. I can,
in principle, do what jEdit does when the docking is changed and create a
new instance of the dockable each time it's dropped into another docking
area, but I think it's a huge waste.
- The 2nd issue can be resolved as I suggested, by adding an attribute to
the dockable element in the dockables.xml file. I am willing to contribute
this code if the jEdit maintainers agree on it. Also my proposal to add a
bsh variable to indicate the existing dockable instance that is moved or
whether a new instance is requested.

I wonder why no one else replied to this mail exchange. Is it because others
are not familiar with the details, or just because they didn't get to it
yet? I don't know how to go on from here. Should I just implement these
changes myself and submit them as patches to the tracker? I really think
flexdock can contribute a lot to jEdit. I wish to finish this plugin quickly
and move on to work on something that, in my opinion, jEdit really needs,
and that's automatic regression testing, to make the maintenance simpler.

Shlomy

On 7/15/07, Marcelo Vanzin <va...@us...> wrote:
>
> On 7/15/07, Shlomy Reinstein <sre...@gm...> wrote:
> > How about using view closed message for all but the last view, and using
> the
> > Plugin.stop() method for the last one?
>
> How about we fix jEdit so that the view closed message is sent anytime
> the view is closed, regardless of whether it's the last one or not?
> Then plugins can have reasonable expectations about what the message
> really means. :-)
>
> The Plugin.stop() thing would work, of course, but it would be just
> another hack on top of the other hacks I already have in PV to try to
> do these things correctly. Basically I have a lot of code there to
> implement two missing things:
>
> - this which we just discussed (closing of the last view)
> - not allowing more than one dockable per view.
>
> If those two were provided by jEdit, I could get rid of a lot of nasty
> code in PV.
>
> --
> Marcelo Vanzin
> mmv...@gm...
> "Life's too short to drink cheap beer."
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> --
> -----------------------------------------------
> jEdit Developers' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>