Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-1701191 ] patch for the nsis2.xml mode file
|
From: SourceForge.net <no...@so...> - 2007-07-03 08:11:30
|
Patches item #1701191, was opened at 2007-04-16 01:56 Message generated for change (Comment added) made by vampire0 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1701191&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Pending Resolution: Accepted Priority: 5 Private: No Submitted By: Uwe (donovaly) >Assigned to: Alan Ezust (ezust) Summary: patch for the nsis2.xml mode file Initial Comment: With the nsis2.xml mode file that comes with jEdit 4.3pre9 there are two issues: - the escape character "&\" has no effect because the literal escape character is double defined. - The NSIS registry root key "SHCTX" is missing in the keyword section while all other root keys are defined there. The attached patch fixes both bugs and fixes also the XML structure (uniform usage of tabs and not mix of spaces and tabs). ---------------------------------------------------------------------- >Comment By: Björn Kautler (vampire0) Date: 2007-07-03 10:11 Message: Logged In: YES user_id=918212 Originator: NO No you didn't. EXCLUDE_MATCH=TRUE => MATCH_TYPE=DEFAULT EXCLUDE_MATCH=FALSE => MATCH_TYPE=RULE The latter is the default value for both attributes. Maybe this should be added to the docs. I mean the translation from EXCLUDE_MATCH to MATCH_TYPE in "Updating Edit Modes" and the default value in "The MATCH_TYPE Attribute". Alan could you add this please? ---------------------------------------------------------------------- Comment By: Björn Kautler (vampire0) Date: 2007-07-03 10:11 Message: Logged In: YES user_id=918212 Originator: NO No you didn't. EXCLUDE_MATCH=TRUE => MATCH_TYPE=DEFAULT EXCLUDE_MATCH=FALSE => MATCH_TYPE=RULE The latter is the default value for both attributes. Maybe this should be added to the docs. I mean the translation from EXCLUDE_MATCH to MATCH_TYPE in "Updating Edit Modes" and the default value in "The MATCH_TYPE Attribute". Alan could you add this please? ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-06-22 04:10 Message: Logged In: YES user_id=935841 Originator: NO Sorry, I was confused. EXCLUDE_MATCH doesn't exist anymore, and so I changed it to a MATCH_TYPE attribute. Since it is a new attr and I'm not 100% sure if I used it correctly, I'd ask that Vampire please check and then we can close it. committed to 9834. ---------------------------------------------------------------------- Comment By: Uwe (donovaly) Date: 2007-06-22 03:35 Message: Logged In: YES user_id=784127 Originator: YES File Added: nsis2.xml ---------------------------------------------------------------------- Comment By: Uwe (donovaly) Date: 2007-06-22 03:34 Message: Logged In: YES user_id=784127 Originator: YES > I can handle this one. Let me ask you, how do you want to be credited in > CHANGES.txt? You can add me there if you like. > Also, is the first .diff missing one of your changes? Please use the latest nsis2.xml I attached. > Would you mind removing the original diff attachment and make a newer one > that has all of your changes in it? I attached a new one, but since I fixed a lot of whitespace nearly every line has been changed. --- I work with the new nsis2.xml version now since over two moths without problems. > The jEdit XML plugin reports an error with this mode file. > <MARK_PREVIOUS TYPE="FUNCTION" EXCLUDE_MATCH="TRUE">::</MARK_PREVIOUS> Not for me. But anyway, I haven't changed this. This is in the file since 2003! File Added: nsis2.diff ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-06-21 04:09 Message: Logged In: YES user_id=935841 Originator: NO Hrm. The jEdit XML plugin reports an error with this mode file. <MARK_PREVIOUS TYPE="FUNCTION" EXCLUDE_MATCH="TRUE">::</MARK_PREVIOUS> The reason is that EXCLUDE_MATCH is not known by jEdit. So I assume this is a new attribute for <MARK_PREVIOUS>? Who added it? We need to update the xmode.dtd accordingly. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-06-21 03:32 Message: Logged In: YES user_id=935841 Originator: NO I can handle this one. Let me ask you, how do you want to be credited in CHANGES.txt? Also, is the first .diff missing one of your changes? Would you mind removing the original diff attachment and make a newer one that has all of your changes in it? ---------------------------------------------------------------------- Comment By: Uwe (donovaly) Date: 2007-04-30 02:37 Message: Logged In: YES user_id=784127 Originator: YES There was another missing keyword "!if". The attached version adds also this one. Does anybody takes care of the patch? File Added: nsis2.xml ---------------------------------------------------------------------- Comment By: Uwe (donovaly) Date: 2007-04-16 01:57 Message: Logged In: YES user_id=784127 Originator: YES File Added: nsis2.diff ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1701191&group_id=588 |