From: SourceForge.net <no...@so...> - 2006-07-12 04:31:27
|
Bugs item #1517395, was opened at 2006-07-05 01:55 Message generated for change (Comment added) made by vanza You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100588&aid=1517395&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: editor core Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Matthieu Casanova (kpouer) Assigned to: Nobody/Anonymous (nobody) Summary: Wrong character encoding in killring.xml Initial Comment: Hi, I got an xml exception when starting jEdit. The reason is that I had in my buffer a character \u0x2 that was not encoded in the killring.xml. When restarting jEdit, I had an exception on the killring.xml load. Way to reproduce : take the attached file, it should contains this 0x2 character. Duplicate the line, delete the first one and save. restart jEdit I did it using Windows XP SP2, jEdit 4.3pre5 (CVS head) ---------------------------------------------------------------------- >Comment By: Marcelo Vanzin (vanza) Date: 2006-07-11 21:31 Message: Logged In: YES user_id=75113 I checked my fix into CVS. So now things should work on 1.5, and stay the same on 1.4 (the error message will change but the result will be the same). Since there's not a "half fixed/half won't fix" resolution, marking as fixed. ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2006-07-10 05:36 Message: Logged In: YES user_id=285591 So I don't have any idea. You tell me that it cannot be fixed until we switch to JDK 1.5. It would be possible to encode that in the xml but this is not a good solution. Maybe doing a specific task when JDK 1.5 is detected ? ---------------------------------------------------------------------- Comment By: Marcelo Vanzin (vanza) Date: 2006-07-07 19:52 Message: Logged In: YES user_id=75113 Matthieu, as Vampire says, the only problem is that the fix wouldn't work on 1.4 at all, since it doesn't support XML 1.1. ---------------------------------------------------------------------- Comment By: Björn Kautler (vampire0) Date: 2006-07-07 01:01 Message: Logged In: YES user_id=918212 Maybe we can use the solution. If you look at devel-list, there has just started a discussion about moving jEdit to Java 5 and even Slava votes for it. :-) ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2006-07-06 23:21 Message: Logged In: YES user_id=285591 Hi Marcello, I'm not an xml expert so I don't know the differences between XML 1.0 and 1.1. Are there reasons to stay in 1.0 ? Do we miss a 1.1 parser ? ---------------------------------------------------------------------- Comment By: Marcelo Vanzin (vanza) Date: 2006-07-06 21:40 Message: Logged In: YES user_id=75113 We have a problem. This fails because 0x2 (and other control characters) are illegal in XML. The solution would be to use a character entity (e.g., ). That requires that the XML file be declared to be "version 1.1" and also requires a 1.1 parser. All works fine and dandy on 1.5, but 1.4's XML parser is not XML 1.1-compatible, so we can't use this solution. So the only way around this would be to lose data... ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2006-07-06 02:18 Message: Logged In: YES user_id=285591 Hi, I just tried again with pre6 compiled from CVS Head and it still happens ---------------------------------------------------------------------- Comment By: Marcelo Vanzin (vanza) Date: 2006-07-05 21:13 Message: Logged In: YES user_id=75113 This should be fixed in CVS now. I'm forcing killring.xml to be saved in UTF-8 now (it was using whatever was the platform's default character encoding). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100588&aid=1517395&group_id=588 |