From: Steve J. <ste...@wi...> - 2006-07-06 20:26:43
|
On 6-Jul-06, at 12:07 PM, Alan Ezust wrote: > Regarding the build files, I wanted to mention, I don't like seeing > any files called "build.properties" in the actual repo. Ideally, the > ones in cvs should always have a .sample suffix on them, so that you > can copy them to .properties and change them. > > Also, those files should be kept as small as possible - the default > sane values should be set inside the build.xml file, rather than the > property files. Agree 100% with the points Alan made above. Also, the 3 properties mentioned by the original poster (below) should DEFINITELY have defaults defined in build.xml. Finally, if you're going to REQUIRE the presence of a build.properties file to define certain properties, then it might be a good idea to have build.xml check to ensure that these properties have been defined, and exit with an appropriate error message for the individual attempting the build if they're not. Steve Jakob > > On 7/6/06, Vampire <Vam...@gm...> wrote: >> >>> I noticed a couple of properties don't have default values; >>> particularly, these ones (I just tried "ant build", so there >>> might be >>> more if you try the other targets): >>> >>> target.java.version >>> build.dir >>> jar.filename >>> >>> I think we should provide reasonable values for the two latter >>> ones. For >>> the first one, I'd say we shouldn't even let the user override >>> it, by >>> declaring it before you try to load "build.properties". (Yes, the >>> user >>> can still define it in the ant command line, but you get my >>> point...) > > jar.filename should be derived from the ant project name, in any case. > |