[ jEdit-devel ] [ jedit-Bugs-485718 ] FTP Save dont preserve owner or sym link

[<no...@so...>]

Bugs item #485718, was opened at 2001-11-26 10:33
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=100588&aid=485718&group_id=588

Category: virtual file systems
Group: normal bug
>Status: Closed
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: FTP Save dont preserve owner or sym link

Initial Comment:
FTP save writes to a #Filename#.ftpsave file, then renames that file to the orginal
filename (over-writing it).  This method does not work in the following situations:
1) Editing file as non-owner, owner is not preserved (goes to logged on owner)
2) Editing a symbolic link, Symbolic link is now a normal file
3) Requires adequate space / permissions in directory as well as file.
4) File mode is cached from open, so you can't chmod it on the machine while editing

Would like to see direct FTP put's instead of .save file (at least optional), as all 4 cases work fine
when just doing a put as opposed to a put <filename>.ftpsave then a rename.

Would be interested in recieving any advice on just "hacking" this feature off for now, as this is 
show-stopping our site upgrade from Version 3.0 (which is btw the absolute best integrated ftp 
editor I have ever seen !!!)

Eric Aksomitis

----------------------------------------------------------------------

>Comment By: Slava Pestov (spestov)
Date: 2001-11-28 00:51

Message:
Logged In: YES 
user_id=2280

jEdit 4.0pre3 adds an option in the global options dialog
box to disable two-stage save.

To "hack" this feature off, edit
org/gjt/sp/jedit/io/BufferIORequest.java in the editor core,
and around line 512, replace this:

String savePath;

if((vfs.getCapabilities() & VFS.RENAME_CAP) != 0)
{
    savePath = vfs.getParentOfPath(path)
        + '#' + vfs.getFileName(path)
        + "#save#";
 }
 else
    savePath = path;

With this:

String savePath = path;

Then, later on, remove or comment out these statements:

if((vfs.getCapabilities() & VFS.RENAME_CAP) != 0)
    vfs._rename(session,savePath,path,view);

Note that this disables two-stage save for all filesystems;
there is no way to do it on a filesystem-specific basis.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=100588&aid=485718&group_id=588