#2783 Escaped quotes messed up (since pre9)

closed-fixed
nobody
8
2007-01-29
2007-01-08
No

Hello All,

Attached file showcases a bug with the PHP syntax highlighting.

The syntax highlighting messes up for me with the first escaped quote in the javascript embedded in the PHP echo statement on line 7 and stays messed up until the closing parenthesis on line 25.

As of SVN revision 8320, I can recreate this on a full "native install" (dist) on a Mac 10.4.8, Intel Core Duo.

Kevin

Discussion

1 2 > >> (Page 1 of 2)
  • PHP Syntax Highlighter Borker

     
    Attachments
    • priority: 5 --> 8
     
  • Logged In: YES
    user_id=285591
    Originator: NO

    This bug appears also in python, but not in java.
    It seems the escape char doesn't work anymore for some languages, no idea of the reason yet.
    The bug appeared between 4.3pre8 and 4.3pre9

     
  • Jakub Roztocil
    Jakub Roztocil
    2007-01-24

    Logged In: YES
    user_id=1504176
    Originator: NO

    This bug appears also in shellscript mode.

     
  • Rodney
    Rodney
    2007-01-25

    Logged In: YES
    user_id=1700880
    Originator: NO

    It looks like, at least with php, this applies only to double quotes. If the string is one enclosed by single quotes then you can add an escaped single quote inside the string without breaking the syntax highlighting.

     
  • daniel hahler
    daniel hahler
    2007-01-25

    Logged In: YES
    user_id=663176
    Originator: NO

    I've been working on the PHP mode file quite a lot in the last months (but not in the last weeks) and I cannot reproduce your issue with it.

    You can get the php.xml at: http://codeprobe.de/pub/jedit/ - just place it in ~/.jedit/modes/.

    I still have some issues to solve (mainly highlighting internal php functions as keywords again, which is a regression to the current mode file).

     
  • daniel hahler
    daniel hahler
    2007-01-25

    • assigned_to: nobody --> blueyed
     
  • Rodney
    Rodney
    2007-01-25

    Logged In: YES
    user_id=1700880
    Originator: NO

    That php.xml file looks like it fixes the quote escaping problem for me.

     
  • daniel hahler
    daniel hahler
    2007-01-25

    • milestone: 101609 --> Regressive (new to devel)
     
  • daniel hahler
    daniel hahler
    2007-01-25

    Logged In: YES
    user_id=663176
    Originator: NO

    I've marked another bug a dupe of this - seems to be caused by the same bug.

    Unassigning myself, because it is not a bug in the php.xml mode file - there just seems to be a workaround in the updated one I've referred to.
    I think bug 1600458 ("Use ESCAPE attribute from imported rules (bind to rule)") might be related.

     
1 2 > >> (Page 1 of 2)