From: Daniel J S. <dan...@ie...> - 2004-11-09 07:05:30
|
Petr Mikulik wrote: >>I updated the key patch and demo. The demo is in PDF format at >> >>http://acer-access.com/~ds...@ac.../gnuplot/key.pdf >> >>The layout of the plot could use small changes here or there, but this >>should be a good first step toward cleanup. >> >> > >I like it, it provides a consistent syntax. > > > >>I'll let it sit for a few months to see what people think. >> >> > >Why not add it to cvs earlier if more people agree? > From what I recall, originally one issue Hans raised was that I used JUSTIFY/VERT_JUSTIFY with the hope of changing that to something consistent like H_JUSTIFY/V_JUSTIFY. But he suggested not doing that because the so large number of occurrences of JUSTIFY. I changed it to what he suggested, a GPKEY_HORIZONTAL, GPKEY_VERTICAL, etc. That is where it was before this small update I made. I remember really cleaning up the key layout nicely, at least in 2D plots. So I think moving it into CVS would be alright, and perhaps a good idea at this time. I probably didn't do as nice a job in 3D because I'm anticipating a discussion at some point at how to make key, color bar, nice 3D borders (Hans' favorite), and general layout that is consistent between 2D and 3D plots (i.e., code reuse). Part of that debate would be whether to hold that off until after a 4.1 version, because there have already been so many changes since 4.0. I'll leave that up to the rest because it sounded like a lot of work to create and publish a version. (What I mean is unifying 2D/3D layout might be upsetting the apple cart a bit to much if other items have priority.) Dan |