Re: proposal for cvs'ing 'with image'

[Ethan M. <merritt@u.washington.edu>]

On Thursday 12 August 2004 06:23 am, Daniel J Sebald wrote:
> 
> I think there was this issue, and the issue about the way a map3d_xy() 
> routine rounds, especially for PostScript.  Ethan said he will be 
> looking at the routine in question some time in the future.

My issue with map3d_xy has nothing to do with rounding.
The problem is that it returns coordinate values as (unsigned int)
without checking for negative numbers.
See numerous bug reports about vector and arrow problems
whenever one end of a vector is outside of the plot area.
When I looked at this before I decided that fixing this properly
might require doing away with the routine altogether, and 
having the callers check for out-of-bound endpoints before
converting input coordinates to (unsigned int) screen coordinates. 

> >I propose clean up of datafile.c, if you really find this necessary, after
> >the patch is in cvs. The patch is quite big, and its maintenance as a
> >patch needs more effort than necessary. Thus I propose to commit the patch
> >ASAP.

OK, I guess.
But please let's try to get df_readline() cleaned up as the very next thing.

And please check one final time that the patched version of datafile.c
does not inadvertantly back out other changes made since 4.0.

-- 
Ethan A Merritt       merritt@u.washington.edu
Biomolecular Structure Center
Mailstop 357742
University of Washington, Seattle, WA 98195