Re: [Gdcm2] gdcm::SerieHelper::SetDirectory()

[Mathieu M. <mat...@gm...>]

Hi Bing,

  Please avoid personal email, as I tend to skip them.

On Wed, Aug 12, 2009 at 12:18 AM, Bing Jian<bin...@gm...> wrote:
> Hi Mathieu,
>
> I am trying to apply itk::GDCMSeriesFileNames on a dicom dataset
> with recursive flag on and noticed a problem of not getting all
> the dicom series. I also noticed that the step of
> itk::GDCMSeriesFileNames::SetDirectory()
> takes very long time and consumes lots of memory, so I looked into
> the source code of
> itk::GDCMSeriesFileNames::SetDirectory()
> which in turn triggers the chain of
> void SerieHelper::SetDirectory(std::string const &dir, bool recursive)
> void SerieHelper::AddFileName(std::string const &filename)
> bool SerieHelper::AddFile(FileWithName &header)
> in gdcmSeriesHelper.cxx
>
> It turns out that in SerieHelper::SetDirectory() the entile file content
> is added to the class member 'SingleSerieUIDFileSetHT'. This may cause
> memory problems as I saw. Do you think it is a good idea to just provide
> a std::map from SeriesUID to FileNames?

I do not know. However what I've learned is that there is nothing
better than a test case. Please send a test case and I'll have a look.

Thanks,
-- 
Mathieu