[Audacity-devel] Re: Working Normally

[<bf...@ew...>]

Replied on devel list ...

At 11:09 pm -0700 23/8/02, Dominic Mazzoni wrote:
>ewitness - Ben Fowler wrote:
>>I suspect that at some point last week, you put in a lot of effort
>>to get include files and the build system back up. So far as I can
>>see, this has been most beneficial, and I shall now commit a short
>>series of patches mainly for the Mac.
>
>Hopefully things work well on Mac OS X.  I still haven't had a
>chance to put in that sort of effort on Mac OS 9, unfortunately.
>
>I just had a chat with Stefan Csomor, the main wxMac developer,
>and we talked about a couple of things we could do so that we
>wouldn't need to actually include wx/mac/private.h at all,
>which we were never supposed to anyway.

You could have helped things along a bit by burning me in effigy,
I suspect.

It was I who began using wx/mac/private.h, so this is my
doing, and actually my fault. The issue was that we (Webbp) needed
a line like

	wxString fName = wxMacFSSpec2MacFilename(&theSpec);

in AudacityApp. As I put it in my mail of 2nd August - which didn't
get onto to the list BTW - this function is defined in 'filefn.cpp'
but declared in 'wx/mac/private.h'.

If you do you want userland code (Audacity) to call
wxMacFSSpec2MacFilename, then this file will need an 'extern'
declaration of that function. I thought that this could be
done by including 'private.h' where that function is defined.

Assuming that you no longer wish to do this, then there are several
courses of action.

1) Regard wxMacFSSpec2MacFilename as internal/private to wxWindows,
locate the correct public function to call and use that (probably
the best idea).

2) Persuade the wxWindows people to provide a preferred public
interface to this function, such as creating a file 'filefn.h'
which contains the necessary.

3) Dummy up a suitable

	WXDLLEXPORT wxString wxMacFSSpec2MacFilename( const FSSpec *spec ) ;

declaration to kludge into this file (and solve the allied problems mentioned
in my mail in the same way).

If you wish me to do any of these, just let me know.

>...  In fact, the only remaining problem
>would be the occasional #include <wx/defs.h> needed, but this is
>NOT just a wxMac problem - header files are different between
>GTK and Windows, too.

There are quite a few header files in the wxWindows library that
do not include wx/defs.h which perhaps should

>>wxWindows is just moving to version 2.3.3 and I shall upgrade to
>>that version on linux (currently 2.3.2) and Mac OS X, intending
>>to stay on that version until there is a later
>>stable one.
>>
>>You might want to recommend that everyone else does the same. The
>>alternative would be to (as is the case with the Mahogany project)
>>request that people use the latest CVS version of wxWindows.
>
>That sounds good.  As soon as 2.3.3 is released, let's make that
>our official version on all platforms.

I am off to Oakham for a week or so, but it looks as though I should
put an announcement on the list to cover these matters.

Obviously all Audacity developers should now download the release
candidate with a view to making it as good as possible to help us
in the long run.

Ben.

-- 
Privileged/Confidential Information may be contained in this message.
If you are not the addressee indicated in this message (or responsible 
for delivery of the message to such person), you may not copy or deliver 
this message to anyone. In such case, you should destroy this message 
and kindly notify the sender by reply email.  Please advise immediately 
if you or your employer do not consent to Internet email messages of this
kind.  Opinions, conclusions and other information in this message that 
do not relate to the official business of ewitness Limited shall be 
understood as neither given nor endorsed by it.

eWitness Limited, Alpha House, Redvers Close, Lawnswood Business Park, Leeds, LS16 6QY
Telephone:  0113 2951112  Fax: 0113 2951114