Re: [Audacity-devel] Would like to add a new effect to Audacity (harmonic-percussive sound separation)

[Steve t. F. <ste...@gm...>]

Thanks for doing the Git repository Viktor. I managed to get this to
build on Linux and have given it a preliminary test drive.

I love the idea of these two effects - really cool :-)
>From the viewpoint of "practical use" I encountered two main problems:

The effects are very slow, and with a large frame size they become
*extremely* slow. Depending on the effect settings, processing just a
few seconds of audio can take several minutes.

The slowness makes it difficult to experiment with different settings,
which may be partly responsible for the second difficulty that I
encountered. While the effects do "work" in terms of separating
different types of sound, I was not able to achieve "usable" sound
quality for musical applications.

HPSS perhaps has some applications in its current form as a research
tool (and it is certainly a very interesting area of research), but
for HPSS to become a "main stream" effect, I think that these two
issues would need considerable improvement. How much improvement do
you (Viktor) think is possible ?

Steve

On 2 October 2015 at 21:08, Viktor Erdélyi <ver...@mp...> wrote:
> Paul,
>
> Thank you for your response. If someone decides to "attempt this" as you
> said, what kind of involvement would be needed from my side? Do I need to
> provide additional input and/or code? (For example, what about adapting the
> existing code to the API defined by the "common code" you mentioned?)
>
> Best regards,
> Viktor Erdélyi
>
>
>
> On 2015-09-30 15:14, Paul Licameli wrote:
>
> I have mentioned before that the general pattern of transforming a sound, by
> taking FFT, changing coefficients, then taking inverse FFT and
> overlap-adding the results, is common to the existing Noise Reduction
> feature and to this project -- and now I see it is also common to a third
> proposed contribution, the project for making irregularly shaped selections
> in spectrogram and filtering them, which was proposed by Luciano Boggino and
> Federico Miyara.
>
> We should not duplicate code.  I want to abstract a common utility out of
> the existing NoiseReduction.cpp for this purpose.
>
> I also lately said, in a conversation off-list, that if we have irregularly
> shaped spectral selections, it would be useful to have spectral
> cut-copy-paste commands.
>
> There could be a convergence of ideas here.  Luciano has done work do define
> and represent irregular shapes that are drawn by hand.  Viktor has an
> algorithm that could deduce a source separation from a signal, and the
> results might be described as a spectral selection.  Then copy and paste
> could effect the separation, or instead one might apply Luciano's effect
> directly to this selection -- to selectively deamplify the drums in a mix,
> for instance.
>
> Managing the long distance collaboration to realize this might be difficult.
> But if we commit to a long cycle for 2.2.0 rather than a short one for
> 2.1.3, it may be good to attempt this.
>
> PRL
>
>
> On Tue, Sep 29, 2015 at 1:10 PM, Viktor Erdélyi <ver...@mp...>
> wrote:
>>
>> Dear all,
>>
>> I am writing in regards to the patch I proposed back in June that adds
>> "harmonic-percussive sound separation" to Audacity as a new effect (also
>> refer to the e-mail below). Let me know if I missed it, but I haven't
>> yet received any feedback on my patch so far. Is it realistic to expect
>> that someone from the development team will look at it in the near
>> future and consider including it in an upcoming release of Audacity?
>>
>> If it is unlikely, how about the possibility to release our effect
>> separately as a pre-compiled patched Audacity binary package on our
>> website (with or without source code)? Do you have any preferences about
>> this?
>>
>> (The patch is available as a fork on GitHub at
>> https://github.com/verdelyi/audacity .)
>>
>> Best regards,
>> Viktor Erdélyi
>>
>> On 2015-06-15 20:28, James Crook wrote:
>> > Hi Viktor,
>> >
>> > Your patch was not ready for us to look at in time for the original
>> > cut-off date for new features for 2.1.1 so we will look at it in the
>> > context of the next release, 2.1.2.  Some planning of the 2.1.2 release
>> > (due end September) can even start right now whilst we are still working
>> > on 2.1.1.  With three month release cycles it is desirable to overlap
>> > the cycles a bit.
>> >
>> > Thanks for your work on this so far.  The BIG change with 2.1.2 is that
>> > we must support wxWidgets 3.0.2.  Whether we do anything about improved
>> > user interface or not, I would also like us to have some discussion of
>> > user interface for separation effects.  For example, if we can classify
>> > some effects as separation effects, we may be able to make nice compound
>> > operations that apply an operation to one component and not the other.
>> > It is not yet clear how that would look from a user interface
>> > perspective.  Paul's spectral selection and noise reduction effects can
>> > both be regarded as separation based effects.
>> >
>> > --James.
>> >
>> > On 15/06/2015 09:49, Viktor Erdélyi wrote:
>> >> Dear Audacity developers,
>> >>
>> >> This is just a friendly reminder to please take a look at my patch (see
>> >> below) that adds the "Harmonic-Percussive Sound Separation" effect (and
>> >> a related vocal removal effect) to Audacity. If there is something I
>> >> can
>> >> do to make your job easier with regard to this patch, let me know.
>> >>
>> >> Best regards,
>> >> Viktor
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > _______________________________________________
>> > audacity-devel mailing list
>> > aud...@li...
>> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>>
>>
>> ------------------------------------------------------------------------------
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>
>
> ------------------------------------------------------------------------------
>
>
>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>