Re: [Audacity-quality] Setting maximum size for Preferences dialog.

[Leland <le...@au...>]

> -----Original Message-----
> From: David Bailes [mailto:drb...@gm...]
> Sent: Thursday, August 27, 2015 5:03 AM
> To: audacity quality <aud...@li...>
> Subject: [Audacity-quality] Setting maximum size for Preferences dialog.
> 
> In the contructor for this dialog, a maximum size of the dialog is set to 800 x
> 627, by this call to SetSizeHints:
> SetSizeHints(sz.x, sz.y + 7 + 20, 800, 627);
> 
> 
> Is there any reason a maximum size needs to be set?
> For viewing keyboard shortcuts, allowing any size would allow the user to
> ensure that they didn't need to scroll horizontally, and also allow them to
> view more shortcuts at the same time.
> 
Looks like I did that back when I converted it to use ShuttleGui:

http://audacity.cvs.sourceforge.net/viewvc/audacity/audacity-src/src/prefs/PrefsDialog.cpp?revision=1.59&view=markup

I'm pretty sure it was back when we had a "rule" that we were trying to support screen sizes down to 800x600.  Setting the maximum would be the only way to guarantee that. (Well, it WAS 6 years ago...not sure I'm remembering it right.)

I say rip it out of there.  It was always a problem for non-English languages anyway.

Leland