Re: [Audacity-devel] Bug 698 - Reverb missing from Chains

[Martyn S. <mar...@gm...>]

Hi Steve

This should really be on Bugzilla, not here.  Please submit a patch 
there so we can look at it.

I've added myself as cc on that bug.

TTFN
Martyn

On 01/04/2014 01:27, Steve the Fiddle wrote:
> I've had a look at this, and the problem appears to be that reverb.h
> does not have the function GetEffectIdentifier
> The problem can be fixed by adding at around line 36:
>
> wxString GetEffectIdentifier() { return wxString(wxT("Reverb"));}
>
> However, I notice that in all other effects GetEffectName,
> GetEffectAction, GetEffectIdentifier and so on are written as virtual
> functions:
>
> virtual wxString GetEffectIdentifier() { return wxString(wxT("Reverb"));}
>
> I don't know what difference that makes (if any) and as it's a P2 bug
> I'll leave the patch to someone that knows.
>
> Also it doesn't have GetEffectCategories, but as we're not currently
> using categories that may not be important.
>
> Steve
>
> ------------------------------------------------------------------------------
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>