Re: [Audacity-devel] Slow update of selection posn on big projects

[Martyn S. <mar...@gm...>]

Thanks Norm!

I see that you have tracked down every (?) instance of *ModifyState 
and added a true or false on whether we should AutoSave that, which 
must have been quite a task!  Well done.  The only one I would argue 
with is TrackPanel::OnSetDisplay where I think it should be 'true'.

I was going to say "why not ModifyState(bool bWantsAutoSave = true)"
and avoid changing those cases, but I think that forcing the coder to 
think about that is wise, in this instance.  Others may differ.  A 
comment about that may be useful.

There is a noticeable and useful speed-up on a 70min single track here.

The patch didn't apply directly here, but that may be down to various 
other patches that I am trying out.  Please try against a fresh 
checkout and re-submit if necessary.

I'll let others contemplate this, but feel free to ping me after 
Christmas if this hasn't made progress.

TTFN
Martyn

On 09/12/2013 01:12, Norm C wrote:
> OK, here's the patch.
>
> NoAutosaveOnSelect.diff
> <http://audacity.238276.n2.nabble.com/file/n7560869/NoAutosaveOnSelect.diff>
>
> New parameter bWantsAutoSave, and it gets set to false for anything that
> looked to me like it was just setting start and/or end selections. Brings
> the multi-second lag down to well under a second on my hour-long 15-track
> project.
>
> Norm
>
>
>
>
> --
> View this message in context: http://audacity.238276.n2.nabble.com/Slow-update-of-selection-posn-on-big-projects-tp7560542p7560869.html
> Sent from the audacity-devel mailing list archive at Nabble.com.
>
> ------------------------------------------------------------------------------
> Sponsored by Intel(R) XDK
> Develop, test and display web and hybrid apps with a single code base.
> Download it for free now!
> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>