Re: [Audacity-devel] many files with wrong line ending

[Richard A. <ri...@au...>]

On Fri, 01 Nov 2013 23:55:30 +0100
Benjamin Drung <bd...@de...> wrote:

> A clean checkout of audacity on Linux contains 450 files with Windows
> file endings. You can see the list by running:
> 
> find * -not -type d -exec file "{}" \; | grep CRLF
> 
> Can someone fix these files and make sure that they have the correct
> line ending on all platforms?

For a good many of these files, CRLF is the correct line ending for the
files on all platforms. For start, if the .sln, .vcxproj, .dsp or .dsw
files don't have the correct line endings (CRLF) then they aren't
useful because they won't open. Ditto other win32 files.

I am also concerned about changing line endings unilaterally in lib-src,
because I think it means upstream patches won't apply neatly to our
tree, and sending patches upstream will get harder. This appears to be
the majority of the files you are complaining about, none of which of
course cause us any problem.

There are some genuine hits in here, but by no means all of the results
from a very simplistic search (which relies on the results produced by
file, which are not always reliable) should be fiddled with, certainly
not without testing.

I'm expecting that at least some of these will cause us problems in the
future - for a start, we have broken the tests for libflac (3rd and 4th
items in the commit list do that), and there will probably be others.

Richard