Re: [Audacity-devel] ExportWAV in batch = Effect with parameters

[Joel B. <bo...@ho...>]

Hello Gale,

thank you for your comments, i will enhance the prototype in the way that you suggest.

I also think that it is more advisable to separate the "chain" preferences from the "menu"
preferences. I intended to do so, but i did not dare introducing new tokens in the preference registry.

I can add two simple commands for "ExportWAV" and "ExportAIFF", while letting the more general command with a different name:  "ExportUncompressed" ? or "ExportPCM" ? ... Technically speaking "ExportPCM" is better because u-Law, a-Law and ADPCM are compressed formats.

Adding the already existing commands "ExportFLAC", "ExportMp3" and "ExportOgg" to the "Effects" is easy. Adding some other common formats selected from the ffmpeg codecs is also feasable. (AAC?, AC3, WMA?, ...). But, at a first glance, implementing the whole custom ffmpeg Export seems difficult. There are so many formats and parameters! I will examine the code more deeply.

Effectively, the sentence "Some frequencies may not be compatible with your hardware" is not very meaningful... But in my first implementation the sentence was: "Some frequencies may not be compatible with the encoding format". I was writing code for validating the sampling frequency against the format, when i noticed that "libsndfile" does not check this!


Best regards,


Joel


----------------------------------------
> Date: Wed, 10 Jul 2013 21:32:23 +0100
> From: ga...@au...
> To: aud...@li...
> Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters
>
>
> | From Joel Bouchat <bo...@ho...>
> | Wed, 10 Jul 2013 02:25:04 +0200
> | Subject: [Audacity-devel] ExportWAV in batch = Effect with parameters
>> Hello Steve,
>>
>> Thank you for your remarks, I will update my source code in consequence.
>> I intend to install a PC under Debian soon, but I still need to find some time (and a PC!).
>>
>> I think also that "ExportWAV" is a bit awkward. It would better be "ExportPCM" but i did
>> not dare modifying the name... Also, most users know what a "WAV" file
>> is, not sure everybody knows that "PCM" means "Pulse Code Modulation" !
>>
>> If i implement a similar process for ExportFLAC, ExportMp3 and ExportOgg, all of them will be in the list in alphabetical order.
>>
>> Now I am going to bed because it is 2:23 AM here !
>
> Hi Joel,
>
> I'm glad to see you having a go at this. It would be of great benefit
> to the people we get on the Forum wanting to batch convert files
> to U-Law and A-Law, just to give one case.
>
> I tried it on Windows Unicode Release. I also had to add
>
> #include <../effects/Effect.h>
>
> to /src/export/ExportPCM.h.
>
> I tested that the sample rate chosen in the ExportWAV dialogue was
> used instead of the project rate for various formats including U-Law.
> That worked fine.
>
> Would it be better to keep Export WAV (meaning 16-bit PCM) as now,
> and just add a sample rate choice for it? Then similarly add Export AIFF
> (16-bit PCM) with a sample rate choice only?
>
> We could then solve what to call the dialogue for now by calling it
> "Export Other Uncompressed" or similar. While that means two more
> export items, it would be much easier for people to choose the two
> common WAV and AIFF choices. It also allows user to have a separate
> Chain choice for an alternative uncompressed export.
>
> I noticed if you set the "Other Uncompressed Files" choice using the
> "Options..." button in the Export File dialogue to some choice other
> than that in the Chain, merely running the Chain resets the standard
> "Other Uncompressed Files" export to the header and encoding in the
> Chain.
>
> IMO it would be a nice enhancement to keep the Chain parameters
> independent of the straight export parameters.
>
> "Some frequencies may not be compatible..." in the ExportWAV dialogue
> is probably superfluous - we don't say that in the Project Rate.
>
> If this is seen as a good approach can you do the same for the FFmpeg
> formats (also heavily requested)?
>
>
> Thanks
>
>
>
> Gale
>
>
>
>> ----------------------------------------
>>> Date: Wed, 10 Jul 2013 00:02:43 +0100
>>> From: ste...@gm...
>>> To: aud...@li...
>>> Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters
>>>
>>> Thanks Joel,
>>>
>>> I had a bit of trouble getting it to build (I'm not a C++ programmer),
>>> but got it to build eventually.
>>>
>>> I had to add:
>>>
>>> #include <./effects/Effect.h>
>>> to ExportPCM.h
>>>
>>> Change:
>>> stricmp
>>> to:
>>> strcasecmp
>>> in ImportPCM.cpp
>>>
>>> There were also a lot of "variable is set but not used" warnings which
>>> I think relate to your patch but these do not prevent building.
>>>
>>> I can't comment on the code (that's beyond my pay scale ;-)
>>>
>>> I've only tested briefly so far but it appears to work fine, and is
>>> **definitely** a useful feature.
>>>
>>> It is a bit peculiar that the Chain command is called "Export WAV" but
>>> the dialogue is the "Export other uncompressed formats" dialogue.
>>>
>>> At the moment it looks odd that Export WAV is separate from the other
>>> Export commands, but personally I think I'd prefer the Export commands
>>> to all be in the alphabetic list.
>>>
>>> Steve
>
>
>
> ------------------------------------------------------------------------------
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel