Re: [Audacity-quality] Align Tracks Together (with labels)
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Steve t. F. <ste...@gm...> - 2013-05-22 13:40:10
|
On 22 May 2013 12:58, David Bailes <drb...@go...> wrote: > On Tue, May 21, 2013 at 7:53 PM, Steve the Fiddle <ste...@gm...> > wrote: >> >> On 21 May 2013 10:03, David Bailes <drb...@go...> wrote: >> >> > >> > Hi Gale, I appear to be loosing my marbles. I misunderstood your reply >> > to >> > robbie on the audacity4blind mailing list in march 2012 when he was >> > asking >> > whether "align with cursor" was available in the exported xml file for >> > keyboard shortcuts. It isn't, but all the align commands can be set in >> > the >> > keyboard category of preferences - I hadn't realised this. One minor >> > problem >> > is that the two sets of commands (with or without moving the cursor) >> > have >> > the same names, which is confusing. >> >> They both use the same sub-menu ("Align Together" is excluded from the >> "and Move Cursor" menu). >> >> If we changed this then the "and Move" menu would need its own sub >> menu rather than reusing the "Align Tracks" sub menu which makes the >> code a bit bulkier, is more to maintain, but the biggest issue is that >> different names would need to be given to the functions. > > > I think that it's ok for the commands in the two sub-menus to have the same > labels. I think that the confusion in the keyboad prefs should be sorted out > there (at some point). > > Also, if on the align tracks menu, both align to/with/from(!) cursor and > align end to end both had predefined shortcuts, then not many people would > need to assign these in keyboard prefs anyway. > > There seems to be a couple of issues about shortcuts in the align tracks > sub-menu: > > 1. If I assign a keyboard shortcut in preferences, the shortcut works, but > doesn't show up after the command in the sub-menu. Assigning a shortcut for > a command in the effects menu shows up in the menu, but I don't know why. The problem is that it's because "alignLabels" is a list of commands that is shared by two sub-menus ("Align Tracks" and "Align Move"), so when an access key is allocated to one of the list items, the menu does not know which occurrence of that item in the menu should have the shortcut assigned to it. In other words, the menu list needs to be unique to one menu item. This problem can be fixed by creating a separate menu list for the "Align/Move" sub-menu so that it is not sharing the same list as "Align Tracks". This can also fix the problem in the keyboard preferences as the menu items can then have unique names. The question then is: what names. The best that I've come up with is: "Tracks > Align Tracks > Align Start to ...." "Tracks > Align and Move Cursor > Move Start to ...." Assuming that I've not missed errors in my code, this patch solves multiple problems, adds a very useful new feature, and I can live with the command names. I think this patch will benefit translation hints. I'm not familiar with translation hints so could someone else do that? Steve > > 2. I'm not sure what code is needed to set up predefined shortcuts in the > align tracks sub-menu. I had a go using SetKeyFromName, using the name > "Align:Align with &Cursor" for the command (this is without your patch > applied) and had no joy. > > David. |