Re: [Audacity-devel] Nyquist Generate Prompt
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Vaughan J. <va...@au...> - 2013-05-15 01:29:41
|
On 5/14/2013 5:03 PM, Steve the Fiddle wrote: > On 15 May 2013 00:26, Martyn Shaw <mar...@gm...> wrote: >> ... >> On 14/05/2013 17:38, Steve the Fiddle wrote: >>> On 14 May 2013 00:51, Martyn Shaw <mar...@gm...> wrote: >>>>... >>>> On 13/05/2013 12:02, Steve the Fiddle wrote: >>>>>... >>>>> On 13 May 2013 00:41, Martyn Shaw <mar...@gm...> wrote: >>>>>>... >> That works here, but duplicates code for no good reason that I can see. > > Yes there would be a lot of duplicate code if this was rolled out for > other effects, which is why I was wondering if it would be better to > move most of it into ErrorDialog.cpp along with void ShowHelpDialog > or perhaps into Effect.cpp as it is about help for effects. Definitely EffectDialog class. > > The problem that I had with using ShowHelpDialog for this was that if > the local file cannot be found, it opens a window telling the user to > download the manual (personally I think that for effect help buttons > it would be more useful to just open the on-line manual if there is no > local manual)... If that's not the desired behavior, then why does ShowHelpDialog do it? Can it be changed to do that without breaking anything? >but then that window cannot be cancelled or closed until > the effect is closed. Browser window, or the "download the manual" alert? Anyway, doesn't matter if we change it to use online, or at least try, if it cannot find local. > ... >> Any why the 'stf' comments? I've done that in the past too but it is >> generally not useful. > > That's just for my own use. kdevelop does not remember bookmarks when > it is closed. They will be removed before submitting a patch for real. Given the comments verbiage, that's what I suspected. ;-) - V |