Re: [Audacity-quality] [Audacity-devel] Introduction and Go to Selection patch

[Gale A. <ga...@au...>]

| From Steve the Fiddle <ste...@gm...> 
| Tue, 23 Apr 2013 22:07:41 +0100
| Subject: [Audacity-quality] [Audacity-devel] Introduction and Go to Selection patch
> On 28 February 2013 01:53, Martyn Shaw <mar...@gm...> wrote:
> > Hi George
> >
> > Thanks for your patch, which I have committed as-is.  Others may well
> > like to change that but I think it is progress on what we had, so I
> > put it in.  We possibly have too many menu items already, but 'View'
> > isn't as long as some.
> >
> > TTFN
> > Martyn
> 
> I'd like to suggest a slight modification to this feature.
> 
> The current View menu order is a bit bizarre.
> Within the first section we have:
> 
> Zoom In  (Ctrl+1)
> Zoom Normal  (Ctrl+2)
> Zoom Out  (Ctrl+3)
> Fit in Window  (Ctrl+F)
> Fit Vertically  (Shift+Ctrl+F)
> Zoom to Selection  (Ctrl+E)
> Go to Selection Start  (Ctrl+4)
> Go to Selection End  (Ctrl+5)
> 
> My suggestion is to put them into order of the default shortcuts:
> 
> Zoom In  (Ctrl+1)
> Zoom Normal  (Ctrl+2)
> Zoom Out  (Ctrl+3)
> Go to Selection Start  (Ctrl+4)
> Go to Selection End  (Ctrl+5)
> Zoom to Selection  (Ctrl+E)
> Fit in Window  (Ctrl+F)
> Fit Vertically  (Shift+Ctrl+F)
> 
> 
> I've attached a patch.
> 
> Steve

Thanks, Steve.

I think it's a slight improvement, but I still question using 
CTRL + number for shortcuts that are not zoom shortcuts.

For example, CTRL + SHIFT + S would be available for 
Go to Selection Start and CTRL + SHIFT + D for Go to 
Selection End. 

Or less of a fingerfull, CTRL + G or CTRL + H, which takes
the next available letters in the alphabet. 

Then we could keep the current menu order or perhaps:   

Zoom In  (Ctrl+1)
Zoom Normal  (Ctrl+2)
Zoom Out  (Ctrl+3)
Zoom to Selection  (Ctrl+E)
Fit in Window  (Ctrl+F)
Fit Vertically  (Shift+Ctrl+F)
Go to Selection Start  (Ctrl+G)
Go to Selection End  (Ctrl+H)

This keeps all the "Zoom", "Fit" and "Go" together and would 
have my vote.

But CTRL + number is my main concern.  




Gale  


> > On 23/02/2013 00:30, George Simon wrote:
> >> Hello!
> >>
> >> I am an avid Audacity user and a curious student developer! I've read
> >> some source and messages on the mailing list, and I've noticed your
> >> nice manners and professional code! I'd love to be able to contribute
> >> to this great project!
> >>
> >>
> >> One thing I have attempted for my use and your consideration:
> >>
> >>
> >> During editing, I come across this situation a lot:
> >>
> >> Inside one audio track, I'd like to cut out a sound clip that I don't
> >> want. However, I want whatever was before and after the part I cut out
> >> to be joined together as seamlessly as possible.
> >>
> >>
> >> I start with making a basic selection, previewing the delete using the
> >> very handy Play Cut Preview function a lot (keyboard shortcut: C),
> >> whittling my selection down to exactly where I like, then making the
> >> delete. Because this is a monotonous task, with lots of tweaking to be
> >> made on both sides of the to-be-deleted-selection, I decided to create
> >> two tools to make my job easier! These tools solve the problem of
> >> being in the wrong place in the track (I.E. not at the beginning or
> >> end of the selection) while you are all the way zoomed in working on
> >> your selection boundaries.
> >>
> >>
> >> Basically, I added a Go to Selection Start command and Go to Selection
> >> End command to the view menu.
> >>
> >> Not only do these commands put you dead center at the start or
> >> beginning of your selection to make it easy to tweak, but they also do
> >> so without messing with your play position, selection boundaries, or
> >> zoom level!
> >>
> >>
> >> I copied and modified the OnZoomSel() function to two new functions:
> >> OnGoSelStart(), and OnGoSelEnd(), and added the appropriate supporting
> >> code (as far as I can tell!) in Menus.cpp and Menus.h.
> >>
> >> The patch is attached to the email.
> >>
> >>
> >> Let me know what you think, and any other way I can help!
> >>
> >>
> >> Thanks and God bless!
> >>
> >> George Simon