Re: [Audacity-devel] Patch: reverb effect
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Steve t. F. <ste...@gm...> - 2013-03-10 21:29:50
|
On 10 March 2013 18:08, Richard Ash <ri...@au...> wrote: > On Mon, 25 Feb 2013 21:52:26 +0000 (GMT) > Rob Sykes <aq...@ya...> wrote: > >> Steve mentioned that there might be interest in grabbing the reverb >> effect from SoX, so here it is: >> http://dl.dropbox.com/u/8835547/reverb.patch >> >> >> This is the freeverb algorithm by 'Jezar', as documented >> here: https://ccrma.stanford.edu/~jos/pasp/Freeverb.html with a few >> additional parameters: > > A few quick questions: > * Why copy the code from libsox, why not just link Audacity to libsox? > Would make future maintenance less painful > * I can see why the "Defaults" button and combo box code belong in > ShuttleGUI (because they will be used in many places), but > PreviewDry? Seems very effect-specific? > > But overall I think this would be good to have, I'm just querying how. > > Richard We probably don't just want the SoX reverb as is. When Rob and myself did initial testing we found that the SoX reverb, while having many advantages over the current GVerb, was rather limited in the range of timbres, hence the additional parameters. The main advantage that I see in writing the code into Audacity rather than just linking to someone else's effect is that if allows us to improve the effect over time. Really good reverb effects can cost $100's, but what makes these stand out from the rest can be very subtle. I think we should avoid the trap this time around of "making do" and leave the path open for future development. My initial impression of this reverb effect is that it is a good start, and much more usable that what we currently have. I'd like to tweak the presets as new controls have been added since those initial presets were written. I'm not 100% about the name of "PreviewDry", but it is very common and frequently useful to have a "bypass" option when previewing effects so as to be able to easily compare with / without the effect (without losing track of the "with" settings). To date we have not used a "bypass" feature, but I think that it could be useful to many effects in the future. Steve |