[Audacity-devel] Fwd: Bugs in 2.0.2

[Vaughan J. <va...@au...>]

Anybody have comments on this?

- V


-------- Original Message --------
Subject: Bugs in 2.0.2
Date: Thu, 30 Aug 2012 21:56:44 +0100
From: Cristian Morales Vega <red...@op...>
To: fee...@au...

- configure --docdir is ignored
- px_unix_oss.c uses isdigit() but doesn't include ctype.h


- This part of the install rule doesn't make a lot of sense
        $(INSTALL) -m 644 images/audacity16.xpm
$(DESTDIR)$(DATADIR)/pixmaps/$(AUDACITY_NAME)16.xpm
        $(INSTALL) -m 644 images/audacity32.xpm
$(DESTDIR)$(DATADIR)/pixmaps/$(AUDACITY_NAME)32.xpm
        # note we don't use the AUDACITY_NAME variable here, because
the mime type
        # doesn't depend on it
        $(INSTALL) -m 644
images/gnome-mime-application-x-audacity-project.xpm
$(DESTDIR)$(DATADIR)/pixmaps/gnome-mime-application-x-audacity-project.xpm

* There are already 16x16 and 32x32 icons installed in
$(DESTDIR)$(DATADIR)/icons/hicolor/
*
http://standards.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html#id2661973
says: "Generally the icon used for a mimetype is created based on the
mime-type by mapping "/" characters to "-"". And
http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#context
specifies a place to put MIME type icons.
So the MIME type icon should be
$(DESTDIR)$(DATADIR)/icons/hicolor/48x48/mimetypes/application-x-audacity-project.xpm.
And there is the problem of the icon being 48x52 instead of 48x48.