Re: [Audacity-devel] release (was Re: [Audacity-quality] bug 528, and another rc?)

[Vaughan J. <va...@au...>]

On 6/29/2012 4:41 PM, Gale Andrews wrote:
> 
> | From Vaughan Johnson <va...@au...> 
> | Fri, 29 Jun 2012 15:42:03 -0700
> | Subject: [Audacity-devel] release (was Re:  [Audacity-quality] bug 528, and another rc?)
>> Looks like he's done it, checking just now. Thanks for that, Gale.
> 
> Yes, as per the below 23:26:51.   
> 
> I think I found my error,  a "require_once"  in main.inc.php that
> I didn't use eventually. 

Sure sounds like you're doing code, there, Gale. We discussed it
recently. If you do that, you should have a developer review it before
committing. Or expect these kinds of results.


> I can fail the home page by adding it 
> back. I only tested main.inc.php against the sidebar, which of 
> course the main page does not have.    

If you're going to code, you should do more thorough testing. And/or ask
somebody else to try out your test version as well, before posting.

And thanks to Buanzo, but there are others of us who know some PHP.


I'd prefer to first closely review all your changes, but I've got to run.

So please go ahead with this, but if it doesn't work, please again
revert to 2.0.0 version immediately, rather than incrementally work on a
broken live site.

The site should never be broken that long, if we can avoid it, and we
readily could have in this case.


> 
> So, looking at my log messages in TortoiseSVN, is the 
> correct step to select r11821:
> http://code.google.com/p/audacity/source/detail?r=11821 
> 
> then "revert changes from this revision", commit that then 
> fix and commit main.inc.php? 

Yes, that should work.


- Vaughan