Re: [Audacity-devel] [Audacity-quality] Repeatable crash set format to 16-bit on read directly 32-b
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Vaughan J. <va...@au...> - 2012-02-29 06:57:24
|
On 2/28/2012 9:40 PM, Michael Chinen wrote: > On Tue, Feb 28, 2012 at 6:48 PM, Vaughan Johnson > <va...@au...> wrote: >> On 2/28/2012 4:27 PM, Bill Wharrie wrote: >>> >>> On 28/02/2012, at 6:33 PM, Vaughan Johnson wrote: >>>> >>>> >>> [snip] >>> >>>> Do the manual editors want to fix those link issues? I think they were >>>> agreed as P1, but obscure, and not worth holding up release. >>> >>> We're going to try. >>> >>> -- Bill >> >> All right, good. My fix for the Sequence::ConsistencyCheck() P1 bug, >> just committed, will not be in the Feb 29 Mac nightly build, so please >> keep me posted on that. >> >> The next 48-hour cycle should start when those are both approved. > > Nice fix, Vaughan! > I tried to look at the crash too but it wasn't so simple and I didn't > figure it out before you did. Thanks, Michael! To be complete, and I should have been more specific: * These P1 bug crashes were in Sequence::ConsistencyCheck() and its calls. * This fix was in Sequence::ConvertToSampleFormat(), back-traced from its calls to Sequence::ConsistencyCheck(). That's a higher level so I hope it may clear remaining bug 451 issues, too... Optimist. :-) > > I tested on mac and it works. Building linux rcs now and will put > them up once I verify them. > > Michael > Thanks! - V |