Re: [Audacity-quality] Borderline P2/P3: Repeatable MP3 import crash if tried by libsndfile

[Michael C. <mc...@gm...>]

On Fri, Feb 3, 2012 at 9:38 AM, Michael Chinen <mc...@gm...> wrote:
> On Fri, Feb 3, 2012 at 8:02 AM, Gale Andrews <ga...@au...> wrote:
>>
>> If you want to consider other borderline P2/P3's, MP3 files that contain
>> duplicated metadata tags will crash Audacity if libsndfile tries them,
>> which seems to be a fault in libsndfile:
>> http://forum.audacityteam.org/viewtopic.php?f=16&t=62791&start=20#p166637 .
>>
> [...]
>
> I'll look at this over the weekend.

I talked to Erik de Castro Lopo on the libsndfile irc and received and
committed his patch in r11457 (already upstream).  This will fix this
bug for most users.

For linux users that use system libs for libsndfile the bug still
exists.  I commited a workaround for this in r11458 & r11459, but this
 means that wavs mislabeled as .mp3 will no longer be read by
libsndfile (only for linux), since users can switch libs and we don't
fix versions at compile time).
Also for system libsndfile on linux, this bug will still exist for
mp3s mislabelled as .wav (still crash).  There's no workaround short
of writing a parser for mp3.

My justification was that preventing a crash is probably better than
having this mislabelled import functionality for mp3, and that this
only affects linux builds.  If some think otherwise, though, please
discuss now.

Michael