[Audacity-devel] updating meters

[Vaughan J. <va...@au...>]

I've fixed bug 258 (P2). Some thoughts that I wrote in the commit comment:

Fix Bug 258 - Mixer Board: max peak and clipping lines removed (P2).

Substantial changes to MixerTrackCluster::UpdateMeter() such that it now
uses the original Meter::UpdateDisplay() rather than the override I wrote.

I think some of the ideas in the override were good though, mainly to
use max and rms from blockfiles rather than passing interleaved sample
buffer to Meter::UpdateDisplay() and having it recalculate those values.
May be worth revisiting. Definitely worth testing for performance issues
relative to 1.3.12.

Also, since all we're doing here is updating the meters, maybe we should
remove it from TrackPanel::OnTimer() and do that in
audacityAudioCallback where it calls
gAudioIO->mOutputMeter->UpdateDisplay(). Thread issues?


Comments on the last two paragraphs?

Thanks,
Vaughan