Re: [Audacity-quality] Sync-lock-look
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Vaughan J. <va...@au...> - 2010-09-09 00:53:20
|
On 9/4/2010 3:23 AM, James Crook wrote: > Guys... > > We're expending a phenomenal amount of energy on the precise details of > the look of sync-lock. Truly. And a lot of it is rehashing things I thought we'd decided. Lots of good comments and insights, but I'm glad I didn't have time to join in until now! :-) At any rate, I made some code changes based on the discussion. More below, including responses to snippets from multiple messages. > > What we have right now for the look is not right, but the feature works > great (in as far as I have used it) in terms of what it does. <snip> > What we have is an evolutionary step forward and it's good. Yes, we've previously discussed its flaws and agreed not to put in the effort, at this time, to do full-fledged grouping/trees. > > > I think the link in the track info does look a bit much like a button, > and that is OK. I tried a few simple ways of dealing with this and committed the one I like best. I commented out the one call to TrackInfo::DrawBordersWithin(). Pretty bold. This eliminates all the dark border lines within the TrackInfo. It leaves some lighter borders, and I think that's an aesthetic improvement, though it may be worse in terms of accessibility. I can also remove the light border above the sync-lock icon, or I could restore all the dark lines except the one above the minimize button rect, but I think this looks best overall. Comments, please. >Maybe at some future date we will think of a way to use > it as a button too. I liked Al's suggestion, but think it's overkill at this point. I agree with Al that Steve's suggestion is a can of worms in terms of specifying correct behavior, and this feature is already relatively hard to understand. Also, it's true what wxToolTips require a wxWindow (e.g., a wxButton), but all the controls in the TrackInfo are "lightweight" and not based on wxWidgets controls. That's why, for example, there's no tooltip for Mute/Solo, and the custom coded ones for the sliders work only while the mouse is down on them, and they're a different font from the wxToolTips (e.g., hover over the toolbar buttons). So, to make the sync-lock icon a button and put a "tooltip" on it would require a good bit more custom code -- not worth the effort, imo. Better to make it not appear to be a button. >I can live with the 'stalag-9' effect of chain link > fencing. I think changing it to a clock will fix that. That's the one thing I didn't do yet. > <snip> > > So, +1/-1 please for the sync-lock being off by default (but the > sync-lock button being visible in the toolbar) for the next few releases. > Yes, we've voted on this more than once already, but +1. _______ Other changes I made: In Track::IsSyncLockSelected(), for the "// Not in a sync-locked group." conditional, it returned true if the track was selected. I made it do so only if track kind is Wave or Label. Among other things, this means Time and Note tracks will never show the sync-lock icon. I think this is correct by definition, but Al, please let me know if this will have negative repercussions elsewhere. There are *lots* of calls to that method and I can move the track-type check to the code that draws the sync-lock icon.. Fixed the bug Gale pointed out where, if a WaveTrack is shrunk such that the sync-lock icon is over a TrackInfo control, such as pan slider, it didn't intercept the mouse event, and passed it on to the control. Now, clicking on the sync-lock icon does nothing. Fixed a bug where the sync-lock icon was redrawn dark when the minimize button is down. Now not redrawn at all in that case. - Vaughan |