Re: [Audacity-quality] Fwd: [Bug 113] Dependencies dialogue not safe against user error
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Gale A. <win...@go...> - 2010-07-17 01:31:47
|
On Sat, Jul 17, 2010 at 1:38 AM, Vaughan Johnson <va...@au...> wrote: > Hi. Not sure if I need to copy these bugzilla notices to this list, but > I think I've resolved this bug(s). Please build and test. > > Thanks, > Vaughan Thanks for all your painstaking work on this. No need to copy here IMHO - Bugzilla is the archive once bugs are on there. Anyway, I can't compile the changes. On Linux Unicode Release: Dependencies.cpp -o Dependencies.o In file included from /usr/include/wx-2.8/wx/event.h:27, from /usr/include/wx-2.8/wx/window.h:19, from /usr/include/wx-2.8/wx/toplevel.h:21, from /usr/include/wx-2.8/wx/dialog.h:17, from Dependencies.cpp:26: /usr/include/wx-2.8/wx/dynarray.h:801:1: warning: "WX_DEFINE_OBJARRAY" redefined In file included from Dependencies.cpp:24: /usr/include/wx-2.8/wx/arrimpl.cpp:120:1: warning: this is the location of the previous definition Dependencies.cpp:57: error: expected constructor, destructor, or type conversion before ‘;’ token make[1]: *** [Dependencies.o] Error 1 make[1]: Leaving directory `/home/gale/audacity/src' make: *** [audacity] Error 2 On Windows Unicode Release: Dependencies.cpp (57): ERROR C4330 missing type specifier - int assumed C++ does not support default-int Gale > -------- Original Message -------- > Subject: [Bug 113] Dependencies dialogue not safe against user error > Date: Fri, 16 Jul 2010 20:35:21 -0400 (EDT) > From: bug...@au... > To: va...@au... > > http://bugzilla.audacityteam.org/show_bug.cgi?id=113 > > > Vaughan Johnson <va...@au...> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Status|ASSIGNED |DEVEL - FIX MADE > > > --- Comment #1 from Vaughan Johnson <va...@au...> > 2010-07-16 20:35:20 EDT --- > (In reply to comment #0) > > Confirmed the first of these, but it's not dependent on loading the file > on-demand. Fixed it with commit r10527. > > The second is not a bug and was not dependent on the import being longer > than a > minute -- I confirmed it with a 30s file. Also probably not dependent on > sample > rate. Anyway, if you trim out 5 seconds and it no longer corresponds to the > alias block file lengths, the data are copied into the project. You can > confirm > by doing the steps listed, deleting the original file, saving and re-opening > the project. Unlike the first item, the audio is there. > > Also fixed a formerly unnoticed crash bug. If user selected a subset of the > dependency files list, then clicked "Copy Selected Audio Into Project", it > removed the selected dependency/dependencies, but then crashed on bad > reference > trying to delete the non-selected dependency/dependencies. This was due to a > consistent misuse of wxHashMap::operator[] to check for the existence of > a hash > element. If you call it with a key that's not in the hash map, yes it > returns > NULL, the first time, but it creates an entry for that key. So if you > test it > again with the same key it returns a bad entry. Replaced it with a > correct call > to wxHashMap::count(). Leland had fixed one of these, but there were 4 more. > This was commit r10530. > > As far as what I've been able to replicate and see in the code, I think this > bug is resolved. > > -- > Configure bugmail: http://bugzilla.audacityteam.org/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are on the CC list for the bug. > You are the assignee for the bug. |