Re: [Audacity-devel] [PATCH] Improvemento for Noise Removal effect

[Michael C. <mc...@gm...>]

On Wed, Jun 30, 2010 at 12:43 AM, Steve the Fiddle
<ste...@gm...> wrote:
> Sadly I don't think the patch works as intended.
>
> I used the nr-ra.patch file that was posted by Richard Ash. The patch
> applied OK without error, but when trying to use the effect I get the same
> result irrespective of the settings used.
>
> Sorry I'm unable to help with the code, but it may help to know that the
> effect is the same as if the noise profile is silence.
I haven't run it, but it looks likes the problem is that there are 2
mSensitivity variables, one in NoiseRemovalDialog and one in
NoiseRemovalEffect, and the slider only affects the
NoiseRemovalDialog's one.  It needs to be transfered over somehow, but
I'm not sure just where since this is a bit of a strange effect.  It
may turn out to be easier to multiply the gain in the GetProfile()
function.

Michael