Re: [Audacity-devel] PATCH import .lnk on Windows
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Al D. <bus...@gm...> - 2009-12-14 17:22:47
|
On Monday 14 December 2009 00:26:58 Ed Musgrove wrote: > Attached is a patch and the resulting source file which allows > Audacity to resolve .lnk files on XP and above. All new code is > wrapped in #ifdef __WXMSW__ and the function is only exercised on > XP or newer Windows. This is fairly important to Windows 7 as all > shortcuts are now .lnks. > > --Ed > 1. The error is specific to drag-and-drop, not to import, right? So shouldn't we resolve the links in, DropTarget::OnDropFiles() in src/Project.cpp instead of Importer::Import? 2. I'm pretty sure shortcuts have always been .lnk files. So you probably don't need to check the Windows version. (This is based on a recollection from almost 10 years ago and some Google searches, so if I'm wrong I'm wrong). Also, the extra header files in src/import/Import.cpp will almost certainly break non-Windows builds. - Al |