Re: [Audacity-devel] P4 Analyze > Plot Spectrum needs progress dialogue.

[Bill W. <bi...@go...>]

On 7-Nov-09, at 10:32 AM, Richard Ash wrote:

> On Wed, 2009-11-04 at 12:34 -0500, Bill Wharrie wrote:
>
>> Would it be useful to put log messages between the time the Plot
>> Spectrum item is chosen and the time Audacity starts to build the
>> progress window?
>
> Yes, I've added them round the GetAudio() method which is called
> imediately before the plotting is done, and which is responsible for  
> the
> too much audio selected dialogue (at the end of the function). I  
> suspect
> that the difference is for some reason your set-up is dominated by the
> time to get the audio data out of the project, rather than the time to
> actually do the analysis, where as here it is definitly the other way
> round. We might have to use two progress bars or something, one for  
> each
> phase (or arbitrarily allocate each of them 50% of the same progress
> bar, accepting it wil change speed half way through).
>
> Changes should show up in tonight's nightly builds.
>
> Richard
>

Here's what I found, selecting 236 seconds of stereo audio

22:54:06: Entering FreqWindow::GetAudio()
22:54:07: Leaving FreqWindow::GetAudio()
22:54:07: Starting FreqWindow::Plot()
22:54:07: Starting FreqWindow::Recalc()
22:54:07: Starting progress dialogue in FreqWindow::Recalc()
22:54:11: Finished updating progress dialogue in FreqWindow::Recalc()
22:54:11: About to draw plot in FreqWindow::Recalc()
22:54:12: Leaving FreqWindow::Plot()

I guess it just *feels* longer than one second waiting for the  
progress window to show up.

Selecting 236 seconds of mono audio:

22:57:07: Entering FreqWindow::GetAudio()
22:57:07: Leaving FreqWindow::GetAudio()
22:57:07: Starting FreqWindow::Plot()
22:57:07: Starting FreqWindow::Recalc()
22:57:07: Starting progress dialogue in FreqWindow::Recalc()
22:57:10: Finished updating progress dialogue in FreqWindow::Recalc()
22:57:10: About to draw plot in FreqWindow::Recalc()
22:57:11: Leaving FreqWindow::Plot()

Little perceptible delay. It looks like the fact that I was selecting  
a stereo track was causing the difference for me. If so, sorry.

I'd say this is good to go.

-- Bill