Re: [Audacity-devel] mp3 export P2
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Gale A. <ga...@au...> - 2008-12-29 19:57:18
|
| From Leland <le...@au...> | Mon, 29 Dec 2008 03:52:02 -0600 | Subject: [Audacity-devel] mp3 export P2 > Leland wrote: > > Leland wrote: > >> I don't seem to have a problem with iTunes playing back a VBR MP3 > >> exported from Audacity. All I did was imported a song and exported it > >> with LAME, VBR, and a quality of 2. > >> > > Even though they would play for me just fine, iTunes did get the length > > of the tune incorrect, so I got to digging and have located the problem. > > I've corrected it here and iTunes is all happy. > > > > But I need to clean it up before committing. > > > Nothing is ever easy is it? ... the options are: > > 1) Don't fix the issue :-) > > 2) Rebuild the 3.98.2 version on Buanzo's site to use the proper > "multi-threaded DLL" runtime library. > > 3) Figure out why LRN's version doesn't work (or use 3.98.2 instead of > alpha code), get rid of the "standalone" lame library on Buanzo's site > and just have people download 1 package to get both ffmpeg and lame > libraries. > > > Personally, I like #3. Especially if an installer is going to be built. > > There's no need to have 2 separate things for a user to do. Call it > the "Audacity Audio Codec" package if you like. But, I don't care really. > > David Bailes wrote: > > Are the licensing issues the same for lame and ffmeg? My understanding > is that thomson, who own some of the mp3 patents, are happy for people > to use lame for non-commercal use. Not sure albout ffmpeg as it > contains the kitchen sink. I don't see the licensing issue. The FFmpeg implementation of LAME (libmp3lame) is LGPL, and the FFmpeg binary we're distributing does not include anything licensed other than under GPL/LGPL. Similarly, libfaac distributed in FFmpeg is LGPL, although AAC as implemented in QuickTime is proprietary? And people can use Audacity for commercial purposes, so this is why we keep LAME distributed offshore, and people can make their own decision if they should be using LAME in Audacity (for whatever their purpose is). I don't see how we can distribute LAME inside FFmpeg for 1.2 users at the moment without causing a lot of confusion. 1.2 users on Windows need lame_enc.dll, not libmp3lame.dll (I assume)? And if we do this for 1.3.7 onwards, is the proposal that the "MP3 files" filter goes, and we have a new one "MP3 files (FFmpeg)", or both? If we agree about the duplication (or not) of filters, then distributing LAME in FFmpeg may be a good idea. It's one download, as you say, and it provides us with a "LAME installer for Windows", which is an aim for 1.4. But in fact, is it better not to make this change until we've got to 1.4, and just rebuild the 3.98.2 LAME on Buanzo's site for now? Is the VBR issue worth fixing in iTunes, anyway? From what I read Apple are being pressured to fix it, because iTunes can't even see the length correctly in VBR MP3 files it encodes itself. Or are we saying that this will fix length issues in VBR files for other apps. than iTunes, once Windows builds of Audacity can actually export VBR files of the correct bit rate and length? Gale |