Re: [Audacity-devel] Getting back in to the swing (Observation of a P1 issue, Bug #286: Noise Remov
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Martyn S. <mar...@go...> - 2008-09-22 22:47:16
|
Thanks for that Dawson, useful analysis! I had a look at the code and committed a fix - mMinSignalBlocks should clearly (to me at least) not be less than 1. That's the bug fixed (although noise removal parameters at lower sampling rates should perhaps be revisited by an interested party in the distant future). Unless anybody has any more useful information, I think that clears a P1 and Bugzilla Bug 286. I'm getting back into it myself, and find that I hadn't even updated to HEAD on my main (win) box for 3 weeks - shocking! Things are slowly setting at work now, so should have more time. TTFN Martyn Dawson Written wrote: > James Crook wrote: >> Our four show stoppers are here: >> >> http://www.audacityteam.org/wiki/index.php?title=Release_Checklist > That first P1issue (Noise Removal) happens when the project rate is set > to any value below 20480 Hz, which causes the int value, > mMinSignalBlocks, to round down to 0 at the top of > EffectNoiseRemoval::Initialize(). When EffectNoiseRemoval::GetProfile() > runs, the value of start is set to the same value as mHistoryLen and > since mSpectrums has mHistoryLen float-pointers allocated, it tries to > set the float value of min to the float of the dereferenced pointer in > the array entry (using the value of start as the index) one past the end > causing the access violation. (Hope that made sense.) > > Setting the project sample rate to 20480 or above, will set > mMinSignalBlocks to 1 or higher and will not result in the violation. > > Either a warning should come up saying a project must have a sample rate > of at least 20480Hz before noise removal profile is performed or the > math and code in effects/NoiseRemoval.cpp needs to be reviewed and > changed. It may just be a typo somewhere. I don't know the algorithm for > noise removal so I will just pass my observation to someone who does. :-) > > Disregard if this information is already known (and being worked on) and > I apologize for the bother. > > Thanks, > Dawson > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |