Re: [Audacity-devel] Generate Noise improvements

[<Mar...@ao...>]

Salvo
 
I'm not sure about this TimeTextCtrl modification.  I was going to  report 
that it breaks the sizing of a floating Selection Toolbar when you change  
formats, but I see it was broken already!  Leland?
 
With regards Preview, none of the other Generate items has it, and it looks  
to me like it was never set up for it.  I think the Preview code will need  a 
little work so perhaps drop the button (for now) and put it on your todo  list?
 
HTH
Martyn
 
In a message dated 16/11/2006 06:53:51 GMT Standard Time,  
ven...@ya... writes:
Ok, now I have put in the wxString format  thing your way:
it works for me as well, so I guess we'll leave it  this
way... I fixed the comment too.

As for the TimeTextCtrl, one fix  is (I tried) to add a
"Fit" call to the parent control anytime the menu  is
invoked. This means that any time a different item in the
format string  menu is chose, the parent control is resized
to fit. Works quite fine for me,  although I haven't tested
the whole application to notice anything wrong with  it.

The change is in line 790-791 of  file
"src/widgets/TimeTextCtrl.cpp" so that it reads  like:

SetFormatString(GetBuiltinFormat(id));
GetParent()->Fit();

This is so that you can give it a try: works for  me.

As for the preview, don't know  :-(

HTH,
.salvo



--- salvatore ventura  <ven...@ya...> ha
scritto:

> Hi,
>   as for the wxString, unfortunately I am new to
> wxWidgets,
> so not  much I can help: I grab usage from all over the
> places, mainly in  existing audacity code, and also add my
> own mistakes to it. What is  surprising is that I don't
> get
> any errors on it...
>  
> Anyway, let me look at what you reported and see if I can
> fix  the resizing: maybe a larger dialog should do... Want
> to see what the  "Generate Silence" dialog does in this
> case.
> 
>  thanks!
> .salvo
> 
> 
> 
> --- Mar...@ao...  ha scritto:
> 
> > Salvo
> > 
> > This is  pretty close to being there, on this platform
> at 
> >  least.  I still got 
> > that compile error and changed cpp li  333  from
> > m_pText_Amplitude = new wxTextCtrl(this,
>  > ID_TEXT_AMPLITUDE,  
> > wxT(wxString::Format(wxT("%g"),  mAmp)),
> > wxDefaultPosition, wxDefaultSize, 0,  
> >  wxTextValidator(wxFILTER_NUMERIC));
> > to
> >  m_pText_Amplitude =  new wxTextCtrl(this,
> > ID_TEXT_AMPLITUDE,  
> > wxString::Format(wxT("%g"), mAmp),   wxDefaultPosition,
> > wxDefaultSize, 0, 
> >  wxTextValidator(wxFILTER_NUMERIC));
> > does  that look ok?   I don't understand the difference
> > (in your our setups or 
>  > the  code, really).
> >  
> > A comment is  wrong at line 279.
> >  
> > There are problems using  TimeTextCtrl here, and I'm not
> > sure how to solve  
>  > them.
> >    1   Preview isn't working  for selections less  than
> > 1s, or with no 
> >  selection made.
> >    2   Changing the format  does not change the size of 
> > the dialog and so 
> >  selecting hh:mm:ss+samples leaves me with the control
> out
> >  of  the dialog and no 
> > way to recover.
> >   
> > But overall it's looking good.  Should go.
> >  Martyn
> > 
> > In a message dated 15/11/2006 09:02:32 GMT  Standard
> Time,
> >  
> >  ven...@ya... writes:
> > Hi,
> > as suggested by  Martyn, I am  splitting the discussion
> > per
> >  item.
> > 
> > The modified Noise generator  involves two  files only,
> > and
> > the patches can be found   here:
> > 
>  >
>
http://www.employees.org/~salvo/downloads/patches/effects/Noise.h.patch
>  > 
>  >
>
http://www.employees.org/~salvo/downloads/patches/effects/Noise.cpp.patch
>  > 
> > thx,
> > .salvo
> > 
> > 
>  > 
> > worth  a  visit...
> >  ======================================
> >  http://www.bytekiln.com
> > http://guidamadrid.altervista.org
>  > http://www.worldbuildingservice.com
> > 
> >  __________________________________________________
> > Do  You  Yahoo!?
> > Poco spazio e tanto spam? Yahoo! Mail ti protegge  dallo
> > spam e ti  da tanto 
> > spazio gratuito per i  tuoi file e i messaggi 
> > http://mail.yahoo.it  
> >  
>  >
>
-------------------------------------------------------------------------
>  > Take  Surveys. Earn Cash. Influence the Future of IT
> > Join  SourceForge.net's Techsay  panel and you'll get
> the
> >  chance to share your
> > opinions on IT & business  topics  through brief surveys
> -
> > and earn  cash
>  >
>
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>  > _______________________________________________
> >  Audacity-devel  mailing  list
> >  Aud...@li...
>  >
>
https://lists.sourceforge.net/lists/listinfo/audacity-devel
>  >  
> > 
>  >
>
-------------------------------------------------------------------------
>  > Take Surveys. Earn Cash. Influence the Future of IT
> > Join  SourceForge.net's Techsay panel and you'll get the
> > chance to share  your
> > opinions on IT & business topics through brief  surveys
> -
> > and earn cash
>  >
>
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>  > _______________________________________________
> > Audacity-devel  mailing list
> > Aud...@li...
>  >
>
https://lists.sourceforge.net/lists/listinfo/audacity-devel
>  > 
> 
> 
> worth a visit...
>  ======================================
> http://www.bytekiln.com
>  http://guidamadrid.altervista.org
>  http://www.worldbuildingservice.com
> 
>  __________________________________________________
> Do You  Yahoo!?
> Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo
>  spam e ti da tanto spazio gratuito per i tuoi file e i
> messaggi 
>  http://mail.yahoo.it 
>  
>
-------------------------------------------------------------------------
>  Take Surveys. Earn Cash. Influence the Future of IT
> Join  SourceForge.net's Techsay panel and you'll get the
> chance to share  your
> opinions on IT & business topics through brief surveys  -
> and earn  cash
>
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>  _______________________________________________
> Audacity-devel mailing  list
>  Aud...@li...
>
https://lists.sourceforge.net/lists/listinfo/audacity-devel
>  


worth a  visit...
======================================
http://www.bytekiln.com
http://guidamadrid.altervista.org
http://www.worldbuildingservice.com

__________________________________________________
Do  You Yahoo!?
Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti  da tanto 
spazio gratuito per i tuoi file e i messaggi 
http://mail.yahoo.it  

-------------------------------------------------------------------------
Take  Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay  panel and you'll get the chance to share your
opinions on IT & business  topics through brief surveys - and earn  cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Audacity-devel  mailing  list
Aud...@li...
https://lists.sourceforge.net/lists/listinfo/audacity-devel