Re: [Audacity-devel] I've committed some chain processing changes

[James C. <cr...@in...>]

My choice would be to use:

       Filter_Length
and   Curve_name

--James.

Mar...@ao... wrote:
>>>> I have some code mostly working here that will retrieve an  EQ curve 
> from a
>>>> string parameter and use it in batch  mode.  Will
>>>> Filter Length=4001 Curve name=Columbia  78
>>>> (note the space in the 'Curve name' parameter) be  OK?
>>> It should work fine as far as what I'm  doing.  It will be up to the EQ 
> code
>>> to parse it out  properly.  All this stuff does is passes it as-is, blank 
> and
>>>  all.
> 
> Hmm.  I modified Shuttle.cpp to implement TransferString, and had to  modify 
> ExchangeWithMaster in the process.  This code uses a space as a  delimiter 
> between the name=value pairs and so if there is a space in a string,  it gets 
> seen as a delimiter.  I put single quotes around the string and  then if a quote 
> is detected as the first char of the value, search through to  the next quote 
> instead of space.  I have also modified the Equalizer to use  this method so 
> that it can be used in effects chains.  Does this sound  OK?  Shall I check it 
> in?
>  
> It does show up a problem with the 'Parameters' box being editable in the  
> current version however - insertion of a space between the = and the quote  
> causes things to go wrong (also for numbers).  Does this box need to be  editable?
>  
> It is possible that the effects chain could specify an EQ curve that is not  
> available.  Should I be trapping that in  EqualizationDialog::setCurve?  I'm 
> not sure what the correct behaviour  should be here: throw up a warning and 
> terminate the chain?
>  
> TTFN
> Martyn