Re: [Audacity-devel] A few changes committed

[<Mar...@ao...>]

Hi Leland
 
I don't know if you remember this from 2 weeks ago...
 
> Sliders in EQ effect are now more VI friendly.  Hey Martyn, try  'em out 
with
> Narrator.  I think you'll like the difference.   Also, I didn't know what to
> call the "length of filter" and what the  value represents (db, hz, samples,
> ...) so I left it alone.

I have tried this and it looks/sounds pretty good to me.  One or two  
comments (as ever):
If I open the Equalisation window and don't touch anything, the chappy  
starts:
 
Foreground window equalization
max decibels slider thirty decibels
dialog klind(?) static text
panel klind
panel klind
63 hertz slider zero decibels
80 hertz slider zero decibels
etc etc, he goes on for as long as I have let him.  He started part  way 
through the sliders (which were not on the screen) then went backwards  through 
Flat, Delete, Save As, Select Curve, then panel, 31Hz, 40Hz, 50Hz,  max dB, 
mindB, 25Hz, 20Hz radio buttons etc..  Should he be reading  out at all at this 
point?
 
If I switch to Graphic EQ when I open the dialog, when I'm keyboarding the  
EQ sliders, chappy reads out the integer number stored in m_sliders[i], whilst  
the ToolTip uses the actual float in m_EQVals[i] (you can increment/decrement 
in  0.1dB steps using shift+up/down).  This means he can say:
twenty hertz, slider, negative one decibel, tooltip twenty hertz hyphen one  
point nine decibels.
(I also not the difference between 'negative' and 'hyphen' here.  I  take it 
that the tooltip is being read by windows.)
 
Similarly with 'Length of Filter' he seems to read a number from 0 to  100, 
not the (this time calculated) proper value as seen in the tooltip or on  the 
right of the slider (see lines 1206-1213).  This value does not really  need a 
unit.
 
HTH, TTFN
Martyn