Re: [Audacity-devel] Fixed data loss bug in CVS HEAD

[Dominic M. <do...@au...>]

On Oct 25, 2005, at 11:48 AM, Markus Meyer wrote:
> Dominic,
>
> that's awesome! And sorry for introducing the bug, it shows that I  
> still don't know much about Audacity's internals :-/

Don't feel bad - copying between projects was something it took me a  
long time to get right.  And I got a good chance to audit your  
WaveClip code in the process; aside from that one problem it looks  
great!

We could add a new type of unit test - the "Run Benchmark" code right  
now will detect bugs in Cut, Copy, and Paste, but we could add a test  
for copying between projects too.

- Dominic

>
> Markus
>
> Dominic Mazzoni schrieb:
>
>
>> I tracked down and fixed the major data loss bug in CVS HEAD.  It   
>> caused data files to end up in the wrong directory when copying   
>> between projects, or when doing a "Save As".  This should be   
>> completely fixed now.
>>
>> In order to fix it, I had to get rid of the WaveClip and Sequence   
>> copy constructors.  However, C++ always creates a default copy   
>> constructor.  Is there any way I could make it a compile-time  
>> error  to call the copy constructor?  I created a private WaveClip  
>> copy  constructor, and that helps - but I'd prefer to even make it  
>> a  compile-time error (or at least warning) even if WaveClip  
>> itself  tries to call its own copy constructor.  Any neat C++ hack  
>> ideas?
>>
>> - Dominic
>>
>>
>>
>> -------------------------------------------------------
>> This SF.Net email is sponsored by the JBoss Inc.
>> Get Certified Today * Register for a JBoss Training Course
>> Free Certification Exam for All Training Attendees Through End of  
>> 2005
>> Visit http://www.jboss.com/services/certification for more  
>> information
>> _______________________________________________
>> Audacity-devel mailing list
>> Aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by the JBoss Inc.
> Get Certified Today * Register for a JBoss Training Course
> Free Certification Exam for All Training Attendees Through End of 2005
> Visit http://www.jboss.com/services/certification for more information
> _______________________________________________
> Audacity-devel mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>