Re: [Audacity-devel] Some work on compressor

[Vaughan J. <va...@au...>]

Markus Meyer wrote:

> Various compressor fixes have been commited to CVS:
>
> * EffectTwoPassSimpleMono has been completely reworked
> * The progress bar behaves as expected now (no restart, no disappearing)
> * Some small bugfixes (e.g. one divison by zero)
> * Added Martyn Shaws compressor code to 1.3 (it seems it was only in 
> 1.2 until now)
>
> I also did tests with valgrind (and found and fixed one delete vs. 
> delete[] bug while doing so ;)), but Valgrind does not indicate any 
> problems with the compressor code.
>
> So please test if the crashes are indeed gone!
>
>
> Markus


Looks good, Markus. I couldn't crash it. Tried several small tests, and 
one that was ~70 minutes. All worked fine.

That testing did show up a bug in Amplify. After I used Compressor with 
"Normalize to 0dB", I could select the ~1:45 track and Amplify thought 
it could be amplified by 0.5dB, but I could see part of it was already 
at 0dB. If I selected just a few seconds around the one place where it 
hit 0dB, Amplify correctly indicated it was already at 0dB.

Another little bug: After Plot Spectrum, now in the Analyze menu, there 
are two consecutive separator bars before the BeatFinder and any other 
plugin effects. And if I select the Analyze menu, before I click a 
command in it, the input level slider blinks continually. That doesn't 
happen with any other menus.

Thanks!

-Vaughan