Re: [Audacity-devel] Compressor problems

[<Mar...@ao...>]

Markus
 
I had a chat with a colleague at work (Chris, who teaches C++ and is very  
bright) and he explained quite a lot to me.  With this and referring to  your 
example code I have implemented pretty much what you said and got it  working 
(although a check over what I've done would be appreciated).  I had  to add a 
couple of files to the project however and I guess that will need  including in 
the various ports.
 
I am left with a (user-type) question.  If you apply compression to a  number 
of tracks and include normalisation, should Audacity apply the same level  of 
normalisation to all the tracks or normalise each track individually?  I  
note that 'Amplify' and 'Normalize' use different ideas here - 'Amplify' appears  
to amplify all the tracks by the same amount whereas 'Normalize' appears to  
amplify each one to a max level of -3dB.  I plump for the first option as  it 
would not muck-up a mix, but what does anyone else think?  (Also, that  it 
what I have implemented.)
 
CVS does not seem to be working at the moment so I am attaching the files I  
have added / changed.  They comprise of...
 
TwoPassSimpleMono.h
which has the declarations of the new Process, FirstPass and SecondPass  
methods.
 
TwoPassSimpleMono.cpp
which has (something similar to) the code you suggested and has dummys for  
InitFirstPass and InitSecondPass (should these return a bool or be void?).
 
Compressor.h
which includes TwoPassSimpleMono.h instead of SimpleMono.h  and contains the 
declarations of the (protected) 'pass' and 'mMax'  variables.
 
Compressor.cpp
which includes the over-rides of the FirstPass and SecondPass  methods.
 
If this works, I guess in the long run it would be better to re-write  
Normalize to use EffectTwoPassSimpleMono instead of reiterating code with minor  
variations?
 
I will add some comments to the code and submit it as a patch if you like  
(and if I can figure out how!).
 
Martyn
PS I t wasn't as difficult as I had thought, given the help of my mate  
Chris!  Or have I made a mess again?
PPS A woman goes into a bar and asks for a double entendre, so the landlord  
gave her one.  (Well, I thought it was funny!)
 
In a message dated 26/09/2005 00:18:42 GMT Standard Time, me...@me...  
writes:
Mar...@ao... schrieb:

>I appreciate the patience you  have all given me but I feel that my C++  
>abilities (zero) are  holding up release of 1.2.4, for which I can only  
apologise.   
>I have looked at your (Markus's) idea to make a two pass  process  and it 
>looks good but I am not able to implement it at my current   level of C++ 
(zero).
>  
>
Martyn,

no problem! I'll  look at it as soon as I find time. I'm afraid that this 
will have to wait  another few days because I will be away on business 
next week, but the  actual programming should be done in one evening or  so.


Markus



-------------------------------------------------------
SF.Net  email is sponsored by:
Tame your development challenges with Apache's  Geronimo App Server. 
Download it for free - -and be entered to win a 42"  plasma tv or your very
own Sony(tm)PSP.  Click here to play:  http://sourceforge.net/geronimo.php
_______________________________________________
Audacity-devel  mailing  list
Aud...@li...
https://lists.sourceforge.net/lists/listinfo/audacity-devel