Re: [Audacity-devel] Simple EffectClickRemoval mostly working ... newbie requesting help to finish

[Dominic M. <do...@au...>]

On Jan 25, 2005, at 10:05 PM, Lynn Allan wrote:
> <alert comment="newbie">
>
> I've uploaded ClickRemovalEffect.zip to:
> http://osdn.dl.sourceforge.net/sourceforge/audacious/ 
> ClickRemovalEffect.zip
> or (if above doesn't work)
> http://www.bibleinverse.org/Misc/ClickRemovalEffect.zip
>
> I "claim" it is about 90+% working as far as detecting and removing
> clicks/pops from a mono speech track (but that may be naive on my part
> :-)

OK, I tried it out, and it seems to work fine on your example.

There are click removal algorithms that actually work even with clicks  
in the middle of a word.  So we will probably eventually want to  
include this as just one of many approaches to click removal.  This  
approach is simpler, but also more foolproof.  Also, your code is ready  
now and it works, while we don't have the other code yet.  So I'd  
definitely rather have this now, over nothing.

I'd almost check it in, but the dialog is pretty broken.  First of all,  
the Panel is not being used at all; it'd be better if you deleted it  
(and made the variable part of the Dialog class).  In the Compressor,  
the Panel is used for the visual display of the compression function.   
Finally, your code never actually reads the value from the edit  
control; the line that would do this (GetValue()) is commented out.   
Instead of putting the prompt ("Click Max Duration:") inside the edit  
text, you should put it in a static text box next to it.  If you're  
confused by the dialog layout code, read the documentation for wxSizer  
and it should make more sense.

- Dominic

> It is "cloned" from EffectCompressor code 1.2.3 and uses
> SimpleMonoEffect.
>
> The .zip includes the following files:
> * ClickRemoval.cpp
> * ClickRemoval.h
> * LoadEffects.cpp
> * audacity.dsp ... Visual Studio project file to reference above files
> * input_clicks.wav
>
> These files are in a directory structure that should unzip into the
> standard Audacity 1.2.3 directories:
> Audacity
> ... src
> ... src\effects\ClickRemoval.cpp
> ... src\effects\ClickRemoval.h
> ... src\effects\LoadEffects.cpp
> ... win\audacity.dsp
>
> Caveats:
> **************
> * Very simplistic logic ... probably just a starting point ... it may
> suffice for my purposes for processing mono vocal speech
> **************
> * Developed using Visual Studio 98 (Visual C++ 6.0 sp6). The
> equivalent of makefiles for other platforms would need to be adjusted
> to incorporate ClickRemoval.cpp and ClickRemoval.h
> **************
> * Assumes mono track that has been normalized and had noise removed.
> Otherwise, there may be residual noise that will appear to be a signal
> that should be retained.)
> **************
> * Dialog to acquire parameters is "stubbed". It should use wxWidget
> text boxes to acquire parameters for:
> - what length of time is considered click (current code is
> "hard-wired" to 0.015 sec of continuous signal strength above a 0.01
> threshold),
>
> - I have effectively zilch wxWidget experience, so was hoping to get
> help from someone with LOTS more wxWidget experience than myself. TIA!
> **************
>
> Let me know if you have questions, and my apologies for residual
> deficiencies in the code.
>
> </alert>
>
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
> Tool for open source databases. Create drag-&-drop reports. Save time
> by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
> Download a FREE copy at http://www.intelliview.com/go/osdn_nl
> _______________________________________________
> Audacity-devel mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel