Thread: [Audacity-devel] Make Stereo Track sometimes drawn incorrectly.
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Steve t. F. <ste...@gm...> - 2013-07-08 20:26:51
Attachments:
MergeSplitTrackHeight.patch
|
I posted this patch last month in relation to the "Pan Envelope Editing" work. Although related to that work, this patch fixes a bug in the current release code, so here it is again separate from the experimental feature. To reproduce the problem: 1) Add two mono tracks to a project. 2) Minimise the upper track. 3) From the drop-down menu of the upper track, select "Make Stereo Track". The left channel of the new stereo track is minimised and the track control panel is drawn incorrectly. 4) Grab the horizontal divide between the left and right channels and drag slowly down. The track control panel corrects itself but the left channel "snaps" to un-minimised and the right channel minimises. I think it would be more sensible for the channels to be resized when joined so as to resolve the above anomaly, which is what the attached patch does. Steve |
From: Gale A. <ga...@au...> - 2013-07-09 11:19:13
|
| From Steve the Fiddle <ste...@gm...> | Mon, 8 Jul 2013 21:26:43 +0100 | Subject: [Audacity-devel] Make Stereo Track sometimes drawn incorrectly. > I posted this patch last month in relation to the "Pan Envelope Editing" work. > Although related to that work, this patch fixes a bug in the current > release code, so here it is again separate from the experimental > feature. > > To reproduce the problem: > 1) Add two mono tracks to a project. > 2) Minimise the upper track. > 3) From the drop-down menu of the upper track, select "Make Stereo Track". > > The left channel of the new stereo track is minimised and the track > control panel is drawn incorrectly. > > 4) Grab the horizontal divide between the left and right channels and > drag slowly down. > > The track control panel corrects itself but the left channel "snaps" > to un-minimised and the right channel minimises. > > I think it would be more sensible for the channels to be resized when > joined so as to resolve the above anomaly, which is what the attached > patch does. > > > Steve Thanks, Steve. I tried it on Windows. If e.g. instead of step 2) I drag the upper track up to "almost collapsed" then Make Stereo Track, I like that the two channels are now the same height (and as before, within the same height that the two mono tracks occupied). It works the same if I drag the upper track up so that it is in effect collapsed. But if I do (what looks visually like) the same thing by using the Collapse button on the upper track to perform your Step 2 , then Make Stereo Track causes the collapsed track to become full height, so the real estate used by the combined track increases. So there is a kind of anomaly there. Is the explanation that a drag collapse isn't treated as a collapse i.e. a drag collapse doesn't expand when you do View > Expand All Tracks? Just a small point anyway - you seem to have fixed the problem you note. Gale |
From: Steve t. F. <ste...@gm...> - 2013-07-09 12:58:05
|
On 9 July 2013 12:18, Gale Andrews <ga...@au...> wrote: > > | From Steve the Fiddle <ste...@gm...> > | Mon, 8 Jul 2013 21:26:43 +0100 > | Subject: [Audacity-devel] Make Stereo Track sometimes drawn incorrectly. >> I posted this patch last month in relation to the "Pan Envelope Editing" work. >> Although related to that work, this patch fixes a bug in the current >> release code, so here it is again separate from the experimental >> feature. >> >> To reproduce the problem: >> 1) Add two mono tracks to a project. >> 2) Minimise the upper track. >> 3) From the drop-down menu of the upper track, select "Make Stereo Track". >> >> The left channel of the new stereo track is minimised and the track >> control panel is drawn incorrectly. >> >> 4) Grab the horizontal divide between the left and right channels and >> drag slowly down. >> >> The track control panel corrects itself but the left channel "snaps" >> to un-minimised and the right channel minimises. >> >> I think it would be more sensible for the channels to be resized when >> joined so as to resolve the above anomaly, which is what the attached >> patch does. >> >> >> Steve > > Thanks, Steve. I tried it on Windows. > > If e.g. instead of step 2) I drag the upper track up to "almost > collapsed" then Make Stereo Track, I like that the two channels > are now the same height (and as before, within the same height > that the two mono tracks occupied). It works the same if I drag > the upper track up so that it is in effect collapsed. There may be some minor cross-platform variations, but the idea is that the real estate used by the stereo track should be about the same as the two original mono tracks. > > But if I do (what looks visually like) the same thing by using the > Collapse button on the upper track to perform your Step 2 , then > Make Stereo Track causes the collapsed track to become full height, > so the real estate used by the combined track increases. This was the main part of the problem. A track should be either collapsed, or not collapsed, but pre-patch, a stereo track could be created that was "half collapsed" (one channel collapsed and the other channel expanded). In the patched version, the stereo track will only be collapsed if both of the mono tracks were collapsed. > So there is a kind of anomaly there. Is the explanation that a drag > collapse isn't treated as a collapse i.e. a drag collapse doesn't > expand when you do View > Expand All Tracks? It's not really an anomaly. The non-collapsed size of the stereo track is always about the same as the non-collapsed size of the two mono tracks combined. Yes it can look a bit strange if you compare combining a "collapsed track" with combining a "minimum height non-collapsed track", but it is totally consistent in its behaviour (as described above). Thanks for testing. Steve > > Just a small point anyway - you seem to have fixed the problem > you note. > > > > > Gale |
From: Joel B. <bo...@ho...> - 2013-07-09 12:50:41
Attachments:
ExportWAV_Effect_0.patch
|
Hello, While going through Audacity "Export" and "Batch" code, i have found the following comment inside the "BatchCommands.cpp" module: // TIDY-ME: Get rid of special commands and make them part of the // 'menu' system (but not showing on the menu) // // ======= IMPORTANT ======== // Special Commands are a KLUDGE whilst we wait for a better system to handle the menu // commands from batch mode. // // Really we should be using a similar (or same) system to that used for effects // so that parameters can be passed to the commands. Many of the menu // commands take a selection as their parameter. I think also that the "Export" commands need parameters when running in batch mode. Therefore, i have tried applying the suggested modification to the "ExportWAV" command. "ExportWAV" is now considered as an "Effect" and it is processed as such. It is still present in the command list, but now in alphabetic order. To avoid modifying the existing "ExportPCMOptions" and "ExportPCM" classes, i have added two new classes inside the "ExportPCM.cpp" module: - "EffectExportPCM" which implements the methods for the "ExportWAV" effect, in the same way as for other effects. - "ExportPCMDialog" for editing the Parameters. This code is stolen from the original "ExportPCMOptions", with the added capability of modifying the Sampling Frequency. Also, this dialog box is an extension of the "EffectDialog" base class. If you think that this feature is valuable, i could do something similar for "ExportFLAC", "ExportMp3" and "ExportOgg". All remarks are welcome, Joël P.S. : - this patch also includes my previous add-ons about the Metadata tags in WAV files, finalized by Vaughan Johnson. - this is only an experimental patch. It is not advisable to include it in Audacity as such. |
From: Steve t. F. <ste...@gm...> - 2013-07-09 13:10:27
|
Unfortunately the patch fails with revision 12421 on Linux. $ patch -p 0 < ExportWAV_Effect_0.patch (Stripping trailing CRs from patch.) patching file src/BatchCommandDialog.cpp (Stripping trailing CRs from patch.) patching file src/BatchCommands.cpp (Stripping trailing CRs from patch.) patching file src/BatchProcessDialog.cpp (Stripping trailing CRs from patch.) patching file src/effects/EffectManager.cpp (Stripping trailing CRs from patch.) patching file src/effects/LoadEffects.cpp (Stripping trailing CRs from patch.) patching file src/export/Export.cpp (Stripping trailing CRs from patch.) patching file src/export/Export.h (Stripping trailing CRs from patch.) patching file src/export/ExportPCM.cpp Hunk #6 FAILED at 128. Hunk #7 FAILED at 167. Hunk #8 FAILED at 182. Hunk #9 FAILED at 200. Hunk #10 FAILED at 233. Hunk #11 FAILED at 282. Hunk #12 FAILED at 355. Hunk #13 succeeded at 452 (offset -7 lines). Hunk #14 FAILED at 608. Hunk #15 FAILED at 621. Hunk #16 succeeded at 763 with fuzz 2 (offset 82 lines). Hunk #17 FAILED at 740. Hunk #18 FAILED at 754. Hunk #19 FAILED at 786. Hunk #20 succeeded at 918 (offset 93 lines). 12 out of 20 hunks FAILED -- saving rejects to file src/export/ExportPCM.cpp.rej (Stripping trailing CRs from patch.) patching file src/export/ExportPCM.h (Stripping trailing CRs from patch.) patching file src/import/ImportPCM.cpp (Stripping trailing CRs from patch.) patching file src/Project.cpp (Stripping trailing CRs from patch.) patching file src/Project.h Steve On 9 July 2013 13:50, Joel Bouchat <bo...@ho...> wrote: > Hello, > > While going through Audacity "Export" and "Batch" code, i have found the following comment inside the "BatchCommands.cpp" module: > > // TIDY-ME: Get rid of special commands and make them part of the > // 'menu' system (but not showing on the menu) > // > // ======= IMPORTANT ======== > // Special Commands are a KLUDGE whilst we wait for a better system to handle the menu > // commands from batch mode. > // > // Really we should be using a similar (or same) system to that used for effects > // so that parameters can be passed to the commands. Many of the menu > // commands take a selection as their parameter. > > I think also that the "Export" commands need parameters when running in batch mode. > Therefore, i have tried applying the suggested modification to the "ExportWAV" command. > "ExportWAV" is now considered as an "Effect" and it is processed as such. > It is still present in the command list, but now in alphabetic order. > To avoid modifying the existing "ExportPCMOptions" and "ExportPCM" classes, i have added two new classes inside the "ExportPCM.cpp" module: > > - "EffectExportPCM" which implements the methods for the "ExportWAV" effect, in the same way as for other effects. > - "ExportPCMDialog" for editing the Parameters. This code is stolen from the original "ExportPCMOptions", with the added capability of modifying the Sampling Frequency. Also, this dialog box is an extension of the "EffectDialog" base class. > > If you think that this feature is valuable, i could do something similar for "ExportFLAC", "ExportMp3" and "ExportOgg". > > All remarks are welcome, > > Joël > > P.S. : > - this patch also includes my previous add-ons about the Metadata tags in WAV files, finalized by Vaughan Johnson. > - this is only an experimental patch. It is not advisable to include it in Audacity as such. > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Joel B. <bo...@ho...> - 2013-07-09 15:11:17
Attachments:
ExportWAV_Effect_1.patch
|
Sorry, the patch had been created against an older revision (Not yet accustomed to SVN!) Here is the patch created from the revision 12421 I could not test it on Unix, hope it works! Best regards, Joel ---------------------------------------- > Date: Tue, 9 Jul 2013 14:10:19 +0100 > From: ste...@gm... > To: aud...@li... > Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters > > Unfortunately the patch fails with revision 12421 on Linux. > > $ patch -p 0 < ExportWAV_Effect_0.patch > (Stripping trailing CRs from patch.) > patching file src/BatchCommandDialog.cpp > (Stripping trailing CRs from patch.) > patching file src/BatchCommands.cpp > (Stripping trailing CRs from patch.) > patching file src/BatchProcessDialog.cpp > (Stripping trailing CRs from patch.) > patching file src/effects/EffectManager.cpp > (Stripping trailing CRs from patch.) > patching file src/effects/LoadEffects.cpp > (Stripping trailing CRs from patch.) > patching file src/export/Export.cpp > (Stripping trailing CRs from patch.) > patching file src/export/Export.h > (Stripping trailing CRs from patch.) > patching file src/export/ExportPCM.cpp > Hunk #6 FAILED at 128. > Hunk #7 FAILED at 167. > Hunk #8 FAILED at 182. > Hunk #9 FAILED at 200. > Hunk #10 FAILED at 233. > Hunk #11 FAILED at 282. > Hunk #12 FAILED at 355. > Hunk #13 succeeded at 452 (offset -7 lines). > Hunk #14 FAILED at 608. > Hunk #15 FAILED at 621. > Hunk #16 succeeded at 763 with fuzz 2 (offset 82 lines). > Hunk #17 FAILED at 740. > Hunk #18 FAILED at 754. > Hunk #19 FAILED at 786. > Hunk #20 succeeded at 918 (offset 93 lines). > 12 out of 20 hunks FAILED -- saving rejects to file src/export/ExportPCM.cpp.rej > (Stripping trailing CRs from patch.) > patching file src/export/ExportPCM.h > (Stripping trailing CRs from patch.) > patching file src/import/ImportPCM.cpp > (Stripping trailing CRs from patch.) > patching file src/Project.cpp > (Stripping trailing CRs from patch.) > patching file src/Project.h > > Steve > > On 9 July 2013 13:50, Joel Bouchat <bo...@ho...> wrote: >> Hello, >> >> While going through Audacity "Export" and "Batch" code, i have found the following comment inside the "BatchCommands.cpp" module: >> >> // TIDY-ME: Get rid of special commands and make them part of the >> // 'menu' system (but not showing on the menu) >> // >> // ======= IMPORTANT ======== >> // Special Commands are a KLUDGE whilst we wait for a better system to handle the menu >> // commands from batch mode. >> // >> // Really we should be using a similar (or same) system to that used for effects >> // so that parameters can be passed to the commands. Many of the menu >> // commands take a selection as their parameter. >> >> I think also that the "Export" commands need parameters when running in batch mode. >> Therefore, i have tried applying the suggested modification to the "ExportWAV" command. >> "ExportWAV" is now considered as an "Effect" and it is processed as such. >> It is still present in the command list, but now in alphabetic order. >> To avoid modifying the existing "ExportPCMOptions" and "ExportPCM" classes, i have added two new classes inside the "ExportPCM.cpp" module: >> >> - "EffectExportPCM" which implements the methods for the "ExportWAV" effect, in the same way as for other effects. >> - "ExportPCMDialog" for editing the Parameters. This code is stolen from the original "ExportPCMOptions", with the added capability of modifying the Sampling Frequency. Also, this dialog box is an extension of the "EffectDialog" base class. >> >> If you think that this feature is valuable, i could do something similar for "ExportFLAC", "ExportMp3" and "ExportOgg". >> >> All remarks are welcome, >> >> Joël >> >> P.S. : >> - this patch also includes my previous add-ons about the Metadata tags in WAV files, finalized by Vaughan Johnson. >> - this is only an experimental patch. It is not advisable to include it in Audacity as such. >> ------------------------------------------------------------------------------ >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> _______________________________________________ >> audacity-devel mailing list >> aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Richard A. <ri...@au...> - 2013-07-09 19:35:33
|
On Mon, 8 Jul 2013 21:26:43 +0100 Steve the Fiddle <ste...@gm...> wrote: > I posted this patch last month in relation to the "Pan Envelope > Editing" work. Although related to that work, this patch fixes a bug > in the current release code, so here it is again separate from the > experimental feature. Thanks you - always easier to commit stuff in smaller pieces. I have committed both of the changes in your patch, but separately - I don't want to mix the code cleanup of unused variables with this fix for behaviour. Thanks also to Gale for testing this on Windows. Richard |
From: Steve t. F. <ste...@gm...> - 2013-07-09 23:02:51
|
Thanks Joel, I had a bit of trouble getting it to build (I'm not a C++ programmer), but got it to build eventually. I had to add: #include <./effects/Effect.h> to ExportPCM.h Change: stricmp to: strcasecmp in ImportPCM.cpp There were also a lot of "variable is set but not used" warnings which I think relate to your patch but these do not prevent building. I can't comment on the code (that's beyond my pay scale ;-) I've only tested briefly so far but it appears to work fine, and is **definitely** a useful feature. It is a bit peculiar that the Chain command is called "Export WAV" but the dialogue is the "Export other uncompressed formats" dialogue. At the moment it looks odd that Export WAV is separate from the other Export commands, but personally I think I'd prefer the Export commands to all be in the alphabetic list. Steve On 9 July 2013 16:11, Joel Bouchat <bo...@ho...> wrote: > Sorry, the patch had been created against an older revision (Not yet accustomed to SVN!) > > > Here is the patch created from the revision 12421 > > I could not test it on Unix, hope it works! > > Best regards, > > Joel > > ---------------------------------------- >> Date: Tue, 9 Jul 2013 14:10:19 +0100 >> From: ste...@gm... >> To: aud...@li... >> Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters >> >> Unfortunately the patch fails with revision 12421 on Linux. >> >> $ patch -p 0 < ExportWAV_Effect_0.patch >> (Stripping trailing CRs from patch.) >> patching file src/BatchCommandDialog.cpp >> (Stripping trailing CRs from patch.) >> patching file src/BatchCommands.cpp >> (Stripping trailing CRs from patch.) >> patching file src/BatchProcessDialog.cpp >> (Stripping trailing CRs from patch.) >> patching file src/effects/EffectManager.cpp >> (Stripping trailing CRs from patch.) >> patching file src/effects/LoadEffects.cpp >> (Stripping trailing CRs from patch.) >> patching file src/export/Export.cpp >> (Stripping trailing CRs from patch.) >> patching file src/export/Export.h >> (Stripping trailing CRs from patch.) >> patching file src/export/ExportPCM.cpp >> Hunk #6 FAILED at 128. >> Hunk #7 FAILED at 167. >> Hunk #8 FAILED at 182. >> Hunk #9 FAILED at 200. >> Hunk #10 FAILED at 233. >> Hunk #11 FAILED at 282. >> Hunk #12 FAILED at 355. >> Hunk #13 succeeded at 452 (offset -7 lines). >> Hunk #14 FAILED at 608. >> Hunk #15 FAILED at 621. >> Hunk #16 succeeded at 763 with fuzz 2 (offset 82 lines). >> Hunk #17 FAILED at 740. >> Hunk #18 FAILED at 754. >> Hunk #19 FAILED at 786. >> Hunk #20 succeeded at 918 (offset 93 lines). >> 12 out of 20 hunks FAILED -- saving rejects to file src/export/ExportPCM.cpp.rej >> (Stripping trailing CRs from patch.) >> patching file src/export/ExportPCM.h >> (Stripping trailing CRs from patch.) >> patching file src/import/ImportPCM.cpp >> (Stripping trailing CRs from patch.) >> patching file src/Project.cpp >> (Stripping trailing CRs from patch.) >> patching file src/Project.h >> >> Steve >> >> On 9 July 2013 13:50, Joel Bouchat <bo...@ho...> wrote: >>> Hello, >>> >>> While going through Audacity "Export" and "Batch" code, i have found the following comment inside the "BatchCommands.cpp" module: >>> >>> // TIDY-ME: Get rid of special commands and make them part of the >>> // 'menu' system (but not showing on the menu) >>> // >>> // ======= IMPORTANT ======== >>> // Special Commands are a KLUDGE whilst we wait for a better system to handle the menu >>> // commands from batch mode. >>> // >>> // Really we should be using a similar (or same) system to that used for effects >>> // so that parameters can be passed to the commands. Many of the menu >>> // commands take a selection as their parameter. >>> >>> I think also that the "Export" commands need parameters when running in batch mode. >>> Therefore, i have tried applying the suggested modification to the "ExportWAV" command. >>> "ExportWAV" is now considered as an "Effect" and it is processed as such. >>> It is still present in the command list, but now in alphabetic order. >>> To avoid modifying the existing "ExportPCMOptions" and "ExportPCM" classes, i have added two new classes inside the "ExportPCM.cpp" module: >>> >>> - "EffectExportPCM" which implements the methods for the "ExportWAV" effect, in the same way as for other effects. >>> - "ExportPCMDialog" for editing the Parameters. This code is stolen from the original "ExportPCMOptions", with the added capability of modifying the Sampling Frequency. Also, this dialog box is an extension of the "EffectDialog" base class. >>> >>> If you think that this feature is valuable, i could do something similar for "ExportFLAC", "ExportMp3" and "ExportOgg". >>> >>> All remarks are welcome, >>> >>> Joël >>> >>> P.S. : >>> - this patch also includes my previous add-ons about the Metadata tags in WAV files, finalized by Vaughan Johnson. >>> - this is only an experimental patch. It is not advisable to include it in Audacity as such. >>> ------------------------------------------------------------------------------ >>> See everything from the browser to the database with AppDynamics >>> Get end-to-end visibility with application monitoring from AppDynamics >>> Isolate bottlenecks and diagnose root cause in seconds. >>> Start your free trial of AppDynamics Pro today! >>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> audacity-devel mailing list >>> aud...@li... >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >>> >> >> ------------------------------------------------------------------------------ >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> _______________________________________________ >> audacity-devel mailing list >> aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Joel B. <bo...@ho...> - 2013-07-10 00:25:14
|
Hello Steve, Thank you for your remarks, I will update my source code in consequence. I intend to install a PC under Debian soon, but I still need to find some time (and a PC!). I think also that "ExportWAV" is a bit awkward. It would better be "ExportPCM" but i did not dare modifying the name... Also, most users know what a "WAV" file is, not sure everybody knows that "PCM" means "Pulse Code Modulation" ! If i implement a similar process for ExportFLAC, ExportMp3 and ExportOgg, all of them will be in the list in alphabetical order. Now I am going to bed because it is 2:23 AM here ! Best regards, Joel ---------------------------------------- > Date: Wed, 10 Jul 2013 00:02:43 +0100 > From: ste...@gm... > To: aud...@li... > Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters > > Thanks Joel, > > I had a bit of trouble getting it to build (I'm not a C++ programmer), > but got it to build eventually. > > I had to add: > > #include <./effects/Effect.h> > to ExportPCM.h > > Change: > stricmp > to: > strcasecmp > in ImportPCM.cpp > > There were also a lot of "variable is set but not used" warnings which > I think relate to your patch but these do not prevent building. > > I can't comment on the code (that's beyond my pay scale ;-) > > I've only tested briefly so far but it appears to work fine, and is > **definitely** a useful feature. > > It is a bit peculiar that the Chain command is called "Export WAV" but > the dialogue is the "Export other uncompressed formats" dialogue. > > At the moment it looks odd that Export WAV is separate from the other > Export commands, but personally I think I'd prefer the Export commands > to all be in the alphabetic list. > > Steve > > > On 9 July 2013 16:11, Joel Bouchat <bo...@ho...> wrote: >> Sorry, the patch had been created against an older revision (Not yet accustomed to SVN!) >> >> >> Here is the patch created from the revision 12421 >> >> I could not test it on Unix, hope it works! >> >> Best regards, >> >> Joel >> >> ---------------------------------------- >>> Date: Tue, 9 Jul 2013 14:10:19 +0100 >>> From: ste...@gm... >>> To: aud...@li... >>> Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters >>> >>> Unfortunately the patch fails with revision 12421 on Linux. >>> >>> $ patch -p 0 < ExportWAV_Effect_0.patch >>> (Stripping trailing CRs from patch.) >>> patching file src/BatchCommandDialog.cpp >>> (Stripping trailing CRs from patch.) >>> patching file src/BatchCommands.cpp >>> (Stripping trailing CRs from patch.) >>> patching file src/BatchProcessDialog.cpp >>> (Stripping trailing CRs from patch.) >>> patching file src/effects/EffectManager.cpp >>> (Stripping trailing CRs from patch.) >>> patching file src/effects/LoadEffects.cpp >>> (Stripping trailing CRs from patch.) >>> patching file src/export/Export.cpp >>> (Stripping trailing CRs from patch.) >>> patching file src/export/Export.h >>> (Stripping trailing CRs from patch.) >>> patching file src/export/ExportPCM.cpp >>> Hunk #6 FAILED at 128. >>> Hunk #7 FAILED at 167. >>> Hunk #8 FAILED at 182. >>> Hunk #9 FAILED at 200. >>> Hunk #10 FAILED at 233. >>> Hunk #11 FAILED at 282. >>> Hunk #12 FAILED at 355. >>> Hunk #13 succeeded at 452 (offset -7 lines). >>> Hunk #14 FAILED at 608. >>> Hunk #15 FAILED at 621. >>> Hunk #16 succeeded at 763 with fuzz 2 (offset 82 lines). >>> Hunk #17 FAILED at 740. >>> Hunk #18 FAILED at 754. >>> Hunk #19 FAILED at 786. >>> Hunk #20 succeeded at 918 (offset 93 lines). >>> 12 out of 20 hunks FAILED -- saving rejects to file src/export/ExportPCM.cpp.rej >>> (Stripping trailing CRs from patch.) >>> patching file src/export/ExportPCM.h >>> (Stripping trailing CRs from patch.) >>> patching file src/import/ImportPCM.cpp >>> (Stripping trailing CRs from patch.) >>> patching file src/Project.cpp >>> (Stripping trailing CRs from patch.) >>> patching file src/Project.h >>> >>> Steve >>> >>> On 9 July 2013 13:50, Joel Bouchat <bo...@ho...> wrote: >>>> Hello, >>>> >>>> While going through Audacity "Export" and "Batch" code, i have found the following comment inside the "BatchCommands.cpp" module: >>>> >>>> // TIDY-ME: Get rid of special commands and make them part of the >>>> // 'menu' system (but not showing on the menu) >>>> // >>>> // ======= IMPORTANT ======== >>>> // Special Commands are a KLUDGE whilst we wait for a better system to handle the menu >>>> // commands from batch mode. >>>> // >>>> // Really we should be using a similar (or same) system to that used for effects >>>> // so that parameters can be passed to the commands. Many of the menu >>>> // commands take a selection as their parameter. >>>> >>>> I think also that the "Export" commands need parameters when running in batch mode. >>>> Therefore, i have tried applying the suggested modification to the "ExportWAV" command. >>>> "ExportWAV" is now considered as an "Effect" and it is processed as such. >>>> It is still present in the command list, but now in alphabetic order. >>>> To avoid modifying the existing "ExportPCMOptions" and "ExportPCM" classes, i have added two new classes inside the "ExportPCM.cpp" module: >>>> >>>> - "EffectExportPCM" which implements the methods for the "ExportWAV" effect, in the same way as for other effects. >>>> - "ExportPCMDialog" for editing the Parameters. This code is stolen from the original "ExportPCMOptions", with the added capability of modifying the Sampling Frequency. Also, this dialog box is an extension of the "EffectDialog" base class. >>>> >>>> If you think that this feature is valuable, i could do something similar for "ExportFLAC", "ExportMp3" and "ExportOgg". >>>> >>>> All remarks are welcome, >>>> >>>> Joël >>>> >>>> P.S. : >>>> - this patch also includes my previous add-ons about the Metadata tags in WAV files, finalized by Vaughan Johnson. >>>> - this is only an experimental patch. It is not advisable to include it in Audacity as such. >>>> ------------------------------------------------------------------------------ >>>> See everything from the browser to the database with AppDynamics >>>> Get end-to-end visibility with application monitoring from AppDynamics >>>> Isolate bottlenecks and diagnose root cause in seconds. >>>> Start your free trial of AppDynamics Pro today! >>>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >>>> _______________________________________________ >>>> audacity-devel mailing list >>>> aud...@li... >>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> See everything from the browser to the database with AppDynamics >>> Get end-to-end visibility with application monitoring from AppDynamics >>> Isolate bottlenecks and diagnose root cause in seconds. >>> Start your free trial of AppDynamics Pro today! >>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> audacity-devel mailing list >>> aud...@li... >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> >> ------------------------------------------------------------------------------ >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> _______________________________________________ >> audacity-devel mailing list >> aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Gale A. <ga...@au...> - 2013-07-10 20:32:44
|
| From Joel Bouchat <bo...@ho...> | Wed, 10 Jul 2013 02:25:04 +0200 | Subject: [Audacity-devel] ExportWAV in batch = Effect with parameters > Hello Steve, > > Thank you for your remarks, I will update my source code in consequence. > I intend to install a PC under Debian soon, but I still need to find some time (and a PC!). > > I think also that "ExportWAV" is a bit awkward. It would better be "ExportPCM" but i did > not dare modifying the name... Also, most users know what a "WAV" file > is, not sure everybody knows that "PCM" means "Pulse Code Modulation" ! > > If i implement a similar process for ExportFLAC, ExportMp3 and ExportOgg, all of them will be in the list in alphabetical order. > > Now I am going to bed because it is 2:23 AM here ! Hi Joel, I'm glad to see you having a go at this. It would be of great benefit to the people we get on the Forum wanting to batch convert files to U-Law and A-Law, just to give one case. I tried it on Windows Unicode Release. I also had to add #include <../effects/Effect.h> to /src/export/ExportPCM.h. I tested that the sample rate chosen in the ExportWAV dialogue was used instead of the project rate for various formats including U-Law. That worked fine. Would it be better to keep Export WAV (meaning 16-bit PCM) as now, and just add a sample rate choice for it? Then similarly add Export AIFF (16-bit PCM) with a sample rate choice only? We could then solve what to call the dialogue for now by calling it "Export Other Uncompressed" or similar. While that means two more export items, it would be much easier for people to choose the two common WAV and AIFF choices. It also allows user to have a separate Chain choice for an alternative uncompressed export. I noticed if you set the "Other Uncompressed Files" choice using the "Options..." button in the Export File dialogue to some choice other than that in the Chain, merely running the Chain resets the standard "Other Uncompressed Files" export to the header and encoding in the Chain. IMO it would be a nice enhancement to keep the Chain parameters independent of the straight export parameters. "Some frequencies may not be compatible..." in the ExportWAV dialogue is probably superfluous - we don't say that in the Project Rate. If this is seen as a good approach can you do the same for the FFmpeg formats (also heavily requested)? Thanks Gale > ---------------------------------------- > > Date: Wed, 10 Jul 2013 00:02:43 +0100 > > From: ste...@gm... > > To: aud...@li... > > Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters > > > > Thanks Joel, > > > > I had a bit of trouble getting it to build (I'm not a C++ programmer), > > but got it to build eventually. > > > > I had to add: > > > > #include <./effects/Effect.h> > > to ExportPCM.h > > > > Change: > > stricmp > > to: > > strcasecmp > > in ImportPCM.cpp > > > > There were also a lot of "variable is set but not used" warnings which > > I think relate to your patch but these do not prevent building. > > > > I can't comment on the code (that's beyond my pay scale ;-) > > > > I've only tested briefly so far but it appears to work fine, and is > > **definitely** a useful feature. > > > > It is a bit peculiar that the Chain command is called "Export WAV" but > > the dialogue is the "Export other uncompressed formats" dialogue. > > > > At the moment it looks odd that Export WAV is separate from the other > > Export commands, but personally I think I'd prefer the Export commands > > to all be in the alphabetic list. > > > > Steve |
From: Joel B. <bo...@ho...> - 2013-07-10 23:22:01
|
Hello Gale, thank you for your comments, i will enhance the prototype in the way that you suggest. I also think that it is more advisable to separate the "chain" preferences from the "menu" preferences. I intended to do so, but i did not dare introducing new tokens in the preference registry. I can add two simple commands for "ExportWAV" and "ExportAIFF", while letting the more general command with a different name: "ExportUncompressed" ? or "ExportPCM" ? ... Technically speaking "ExportPCM" is better because u-Law, a-Law and ADPCM are compressed formats. Adding the already existing commands "ExportFLAC", "ExportMp3" and "ExportOgg" to the "Effects" is easy. Adding some other common formats selected from the ffmpeg codecs is also feasable. (AAC?, AC3, WMA?, ...). But, at a first glance, implementing the whole custom ffmpeg Export seems difficult. There are so many formats and parameters! I will examine the code more deeply. Effectively, the sentence "Some frequencies may not be compatible with your hardware" is not very meaningful... But in my first implementation the sentence was: "Some frequencies may not be compatible with the encoding format". I was writing code for validating the sampling frequency against the format, when i noticed that "libsndfile" does not check this! Best regards, Joel ---------------------------------------- > Date: Wed, 10 Jul 2013 21:32:23 +0100 > From: ga...@au... > To: aud...@li... > Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters > > > | From Joel Bouchat <bo...@ho...> > | Wed, 10 Jul 2013 02:25:04 +0200 > | Subject: [Audacity-devel] ExportWAV in batch = Effect with parameters >> Hello Steve, >> >> Thank you for your remarks, I will update my source code in consequence. >> I intend to install a PC under Debian soon, but I still need to find some time (and a PC!). >> >> I think also that "ExportWAV" is a bit awkward. It would better be "ExportPCM" but i did >> not dare modifying the name... Also, most users know what a "WAV" file >> is, not sure everybody knows that "PCM" means "Pulse Code Modulation" ! >> >> If i implement a similar process for ExportFLAC, ExportMp3 and ExportOgg, all of them will be in the list in alphabetical order. >> >> Now I am going to bed because it is 2:23 AM here ! > > Hi Joel, > > I'm glad to see you having a go at this. It would be of great benefit > to the people we get on the Forum wanting to batch convert files > to U-Law and A-Law, just to give one case. > > I tried it on Windows Unicode Release. I also had to add > > #include <../effects/Effect.h> > > to /src/export/ExportPCM.h. > > I tested that the sample rate chosen in the ExportWAV dialogue was > used instead of the project rate for various formats including U-Law. > That worked fine. > > Would it be better to keep Export WAV (meaning 16-bit PCM) as now, > and just add a sample rate choice for it? Then similarly add Export AIFF > (16-bit PCM) with a sample rate choice only? > > We could then solve what to call the dialogue for now by calling it > "Export Other Uncompressed" or similar. While that means two more > export items, it would be much easier for people to choose the two > common WAV and AIFF choices. It also allows user to have a separate > Chain choice for an alternative uncompressed export. > > I noticed if you set the "Other Uncompressed Files" choice using the > "Options..." button in the Export File dialogue to some choice other > than that in the Chain, merely running the Chain resets the standard > "Other Uncompressed Files" export to the header and encoding in the > Chain. > > IMO it would be a nice enhancement to keep the Chain parameters > independent of the straight export parameters. > > "Some frequencies may not be compatible..." in the ExportWAV dialogue > is probably superfluous - we don't say that in the Project Rate. > > If this is seen as a good approach can you do the same for the FFmpeg > formats (also heavily requested)? > > > Thanks > > > > Gale > > > >> ---------------------------------------- >>> Date: Wed, 10 Jul 2013 00:02:43 +0100 >>> From: ste...@gm... >>> To: aud...@li... >>> Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters >>> >>> Thanks Joel, >>> >>> I had a bit of trouble getting it to build (I'm not a C++ programmer), >>> but got it to build eventually. >>> >>> I had to add: >>> >>> #include <./effects/Effect.h> >>> to ExportPCM.h >>> >>> Change: >>> stricmp >>> to: >>> strcasecmp >>> in ImportPCM.cpp >>> >>> There were also a lot of "variable is set but not used" warnings which >>> I think relate to your patch but these do not prevent building. >>> >>> I can't comment on the code (that's beyond my pay scale ;-) >>> >>> I've only tested briefly so far but it appears to work fine, and is >>> **definitely** a useful feature. >>> >>> It is a bit peculiar that the Chain command is called "Export WAV" but >>> the dialogue is the "Export other uncompressed formats" dialogue. >>> >>> At the moment it looks odd that Export WAV is separate from the other >>> Export commands, but personally I think I'd prefer the Export commands >>> to all be in the alphabetic list. >>> >>> Steve > > > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Gale A. <ga...@au...> - 2013-07-11 00:36:19
|
| From Joel Bouchat <bo...@ho...> | Thu, 11 Jul 2013 01:21:53 +0200 | Subject: [Audacity-devel] ExportWAV in batch = Effect with parameters > I can add two simple commands for "ExportWAV" and "ExportAIFF", while > letting the more general command with a different name: > "ExportUncompressed" ? or "ExportPCM" ? ... Technically speaking > "ExportPCM" is better because u-Law, a-Law and ADPCM are compressed > formats. On the other hand not all the options in there are PCM. More than a few users don't make a connection between "Other uncompressed files" and *Law / ADPCM, and some don't even think to look there for 24 or 32-bit PCM. I've been wondering if this menu item in the Export File list should be specific e.g. "Uncompressed Files: 24/32-bit, ADPCM, U-Law etc." It wouldn't fit in the current export file drop-down without the window being a bit wider, but you would still see it if you clicked the menu. Anyway let's see if anyone disagrees that we want to keep WAV and AIFF as separate commands. > Adding the already existing commands "ExportFLAC", "ExportMp3" > and "ExportOgg" to the "Effects" is easy. Adding some other common > formats selected from the ffmpeg codecs is also feasable. (AAC?, AC3, > WMA?, ...). But, at a first glance, implementing the whole custom > ffmpeg Export seems difficult. There are so many formats and > parameters! I will examine the code more deeply. For now, I'd only thought of adding the four FFmpeg formats that are in the export drop-down i.e. M4A, WMA, AC3, AMR NB. If you wanted a "Custom FFmpeg" export command for Chains I suppose you could just open the Custom FFmpeg Export dialog directly? It already includes a sample rate choice, though as you can see from the dialog, the tooltip says not to change the sample rate there. The problem is that a fair number of the combinations offered in the Custom FFmpeg dialogue export zero bytes or small invalid files, even though they export correctly in standalone FFmpeg: http://bugzilla.audacityteam.org/show_bug.cgi?id=59 . By the way I thought you were following "TIDY-ME: Get rid of special commands and make them part of the 'menu' system (but not showing on the menu)" . but I see the Effect Menu has a new command "Exporting WAV file..." Gale > Effectively, the sentence "Some frequencies may not be compatible > with your hardware" is not very meaningful... But in my first > implementation the sentence was: "Some frequencies may not be > compatible with the encoding format". I was writing code for > validating the sampling frequency against the format, when i noticed > that "libsndfile" does not check this! > > > Best regards, > > > Joel > > > ---------------------------------------- > > Date: Wed, 10 Jul 2013 21:32:23 +0100 > > From: ga...@au... > > To: aud...@li... > > Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters > > > > > > | From Joel Bouchat <bo...@ho...> > > | Wed, 10 Jul 2013 02:25:04 +0200 > > | Subject: [Audacity-devel] ExportWAV in batch = Effect with parameters > >> Hello Steve, > >> > >> Thank you for your remarks, I will update my source code in consequence. > >> I intend to install a PC under Debian soon, but I still need to find some time (and a PC!). > >> > >> I think also that "ExportWAV" is a bit awkward. It would better be "ExportPCM" but i did > >> not dare modifying the name... Also, most users know what a "WAV" file > >> is, not sure everybody knows that "PCM" means "Pulse Code Modulation" ! > >> > >> If i implement a similar process for ExportFLAC, ExportMp3 and ExportOgg, all of them will be in the list in alphabetical order. > >> > >> Now I am going to bed because it is 2:23 AM here ! > > > > Hi Joel, > > > > I'm glad to see you having a go at this. It would be of great benefit > > to the people we get on the Forum wanting to batch convert files > > to U-Law and A-Law, just to give one case. > > > > I tried it on Windows Unicode Release. I also had to add > > > > #include <../effects/Effect.h> > > > > to /src/export/ExportPCM.h. > > > > I tested that the sample rate chosen in the ExportWAV dialogue was > > used instead of the project rate for various formats including U-Law. > > That worked fine. > > > > Would it be better to keep Export WAV (meaning 16-bit PCM) as now, > > and just add a sample rate choice for it? Then similarly add Export AIFF > > (16-bit PCM) with a sample rate choice only? > > > > We could then solve what to call the dialogue for now by calling it > > "Export Other Uncompressed" or similar. While that means two more > > export items, it would be much easier for people to choose the two > > common WAV and AIFF choices. It also allows user to have a separate > > Chain choice for an alternative uncompressed export. > > > > I noticed if you set the "Other Uncompressed Files" choice using the > > "Options..." button in the Export File dialogue to some choice other > > than that in the Chain, merely running the Chain resets the standard > > "Other Uncompressed Files" export to the header and encoding in the > > Chain. > > > > IMO it would be a nice enhancement to keep the Chain parameters > > independent of the straight export parameters. > > > > "Some frequencies may not be compatible..." in the ExportWAV dialogue > > is probably superfluous - we don't say that in the Project Rate. > > > > If this is seen as a good approach can you do the same for the FFmpeg > > formats (also heavily requested)? > > > > > > Thanks > > > > > > > > Gale > > > > > > > >> ---------------------------------------- > >>> Date: Wed, 10 Jul 2013 00:02:43 +0100 > >>> From: ste...@gm... > >>> To: aud...@li... > >>> Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters > >>> > >>> Thanks Joel, > >>> > >>> I had a bit of trouble getting it to build (I'm not a C++ programmer), > >>> but got it to build eventually. > >>> > >>> I had to add: > >>> > >>> #include <./effects/Effect.h> > >>> to ExportPCM.h > >>> > >>> Change: > >>> stricmp > >>> to: > >>> strcasecmp > >>> in ImportPCM.cpp > >>> > >>> There were also a lot of "variable is set but not used" warnings which > >>> I think relate to your patch but these do not prevent building. > >>> > >>> I can't comment on the code (that's beyond my pay scale ;-) > >>> > >>> I've only tested briefly so far but it appears to work fine, and is > >>> **definitely** a useful feature. > >>> > >>> It is a bit peculiar that the Chain command is called "Export WAV" but > >>> the dialogue is the "Export other uncompressed formats" dialogue. > >>> > >>> At the moment it looks odd that Export WAV is separate from the other > >>> Export commands, but personally I think I'd prefer the Export commands > >>> to all be in the alphabetic list. > >>> > >>> Steve > > > > > > > > ------------------------------------------------------------------------------ > > See everything from the browser to the database with AppDynamics > > Get end-to-end visibility with application monitoring from AppDynamics > > Isolate bottlenecks and diagnose root cause in seconds. > > Start your free trial of AppDynamics Pro today! > > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > > _______________________________________________ > > audacity-devel mailing list > > aud...@li... > > https://lists.sourceforge.net/lists/listinfo/audacity-devel > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Gary N. <por...@gm...> - 2013-07-11 02:18:16
|
My perspective is that PCM is a generic term for 2s complement binary coded data with any number of bits per sample. .wav is PCM with specific metadata, header format, etc. such as track name, sampling freq in Hz (32 bit integer), track number (16 bit integer). PCM is not a file format, it is an encoding method. AIFF is PCM with different header format. Btw. I just this day recorded a number of named files with 1000000Hz sampling freq and ported the to audacity. File names came in as track names and sample freq also displayed correctly in the track info area. Sent from my iPhone. Bits per sample also came in correctly. So .wav imports with the necessary info. I would like to be able to add GPS coordinates and time of recordings. Good discussion. Audacity is great for porpoise file editing. Gary Nelson On Jul 10, 2013, at 5:35 PM, Gale Andrews <ga...@au...> wrote: > > | From Joel Bouchat <bo...@ho...> > | Thu, 11 Jul 2013 01:21:53 +0200 > | Subject: [Audacity-devel] ExportWAV in batch = Effect with parameters >> I can add two simple commands for "ExportWAV" and "ExportAIFF", while >> letting the more general command with a different name: >> "ExportUncompressed" ? or "ExportPCM" ? ... Technically speaking >> "ExportPCM" is better because u-Law, a-Law and ADPCM are compressed >> formats. > > On the other hand not all the options in there are PCM. > > More than a few users don't make a connection between "Other > uncompressed files" and *Law / ADPCM, and some don't even > think to look there for 24 or 32-bit PCM. I've been wondering > if this menu item in the Export File list should be specific e.g. > > "Uncompressed Files: 24/32-bit, ADPCM, U-Law etc." > > It wouldn't fit in the current export file drop-down without the > window being a bit wider, but you would still see it if you clicked > the menu. > > Anyway let's see if anyone disagrees that we want to keep WAV > and AIFF as separate commands. > > >> Adding the already existing commands "ExportFLAC", "ExportMp3" >> and "ExportOgg" to the "Effects" is easy. Adding some other common >> formats selected from the ffmpeg codecs is also feasable. (AAC?, AC3, >> WMA?, ...). But, at a first glance, implementing the whole custom >> ffmpeg Export seems difficult. There are so many formats and >> parameters! I will examine the code more deeply. > > For now, I'd only thought of adding the four FFmpeg formats that are > in the export drop-down i.e. M4A, WMA, AC3, AMR NB. > > If you wanted a "Custom FFmpeg" export command for Chains I > suppose you could just open the Custom FFmpeg Export dialog > directly? It already includes a sample rate choice, though as you > can see from the dialog, the tooltip says not to change the sample > rate there. > > The problem is that a fair number of the combinations offered in the > Custom FFmpeg dialogue export zero bytes or small invalid files, > even though they export correctly in standalone FFmpeg: > http://bugzilla.audacityteam.org/show_bug.cgi?id=59 . > > By the way I thought you were following > > "TIDY-ME: Get rid of special commands and make them part of the > 'menu' system (but not showing on the menu)" . > > but I see the Effect Menu has a new command "Exporting WAV > file..." > > > > Gale > > >> Effectively, the sentence "Some frequencies may not be compatible >> with your hardware" is not very meaningful... But in my first >> implementation the sentence was: "Some frequencies may not be >> compatible with the encoding format". I was writing code for >> validating the sampling frequency against the format, when i noticed >> that "libsndfile" does not check this! >> >> >> Best regards, >> >> >> Joel >> >> >> ---------------------------------------- >>> Date: Wed, 10 Jul 2013 21:32:23 +0100 >>> From: ga...@au... >>> To: aud...@li... >>> Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters >>> >>> >>> | From Joel Bouchat <bo...@ho...> >>> | Wed, 10 Jul 2013 02:25:04 +0200 >>> | Subject: [Audacity-devel] ExportWAV in batch = Effect with parameters >>>> Hello Steve, >>>> >>>> Thank you for your remarks, I will update my source code in consequence. >>>> I intend to install a PC under Debian soon, but I still need to find some time (and a PC!). >>>> >>>> I think also that "ExportWAV" is a bit awkward. It would better be "ExportPCM" but i did >>>> not dare modifying the name... Also, most users know what a "WAV" file >>>> is, not sure everybody knows that "PCM" means "Pulse Code Modulation" ! >>>> >>>> If i implement a similar process for ExportFLAC, ExportMp3 and ExportOgg, all of them will be in the list in alphabetical order. >>>> >>>> Now I am going to bed because it is 2:23 AM here ! >>> >>> Hi Joel, >>> >>> I'm glad to see you having a go at this. It would be of great benefit >>> to the people we get on the Forum wanting to batch convert files >>> to U-Law and A-Law, just to give one case. >>> >>> I tried it on Windows Unicode Release. I also had to add >>> >>> #include <../effects/Effect.h> >>> >>> to /src/export/ExportPCM.h. >>> >>> I tested that the sample rate chosen in the ExportWAV dialogue was >>> used instead of the project rate for various formats including U-Law. >>> That worked fine. >>> >>> Would it be better to keep Export WAV (meaning 16-bit PCM) as now, >>> and just add a sample rate choice for it? Then similarly add Export AIFF >>> (16-bit PCM) with a sample rate choice only? >>> >>> We could then solve what to call the dialogue for now by calling it >>> "Export Other Uncompressed" or similar. While that means two more >>> export items, it would be much easier for people to choose the two >>> common WAV and AIFF choices. It also allows user to have a separate >>> Chain choice for an alternative uncompressed export. >>> >>> I noticed if you set the "Other Uncompressed Files" choice using the >>> "Options..." button in the Export File dialogue to some choice other >>> than that in the Chain, merely running the Chain resets the standard >>> "Other Uncompressed Files" export to the header and encoding in the >>> Chain. >>> >>> IMO it would be a nice enhancement to keep the Chain parameters >>> independent of the straight export parameters. >>> >>> "Some frequencies may not be compatible..." in the ExportWAV dialogue >>> is probably superfluous - we don't say that in the Project Rate. >>> >>> If this is seen as a good approach can you do the same for the FFmpeg >>> formats (also heavily requested)? >>> >>> >>> Thanks >>> >>> >>> >>> Gale >>> >>> >>> >>>> ---------------------------------------- >>>>> Date: Wed, 10 Jul 2013 00:02:43 +0100 >>>>> From: ste...@gm... >>>>> To: aud...@li... >>>>> Subject: Re: [Audacity-devel] ExportWAV in batch = Effect with parameters >>>>> >>>>> Thanks Joel, >>>>> >>>>> I had a bit of trouble getting it to build (I'm not a C++ programmer), >>>>> but got it to build eventually. >>>>> >>>>> I had to add: >>>>> >>>>> #include <./effects/Effect.h> >>>>> to ExportPCM.h >>>>> >>>>> Change: >>>>> stricmp >>>>> to: >>>>> strcasecmp >>>>> in ImportPCM.cpp >>>>> >>>>> There were also a lot of "variable is set but not used" warnings which >>>>> I think relate to your patch but these do not prevent building. >>>>> >>>>> I can't comment on the code (that's beyond my pay scale ;-) >>>>> >>>>> I've only tested briefly so far but it appears to work fine, and is >>>>> **definitely** a useful feature. >>>>> >>>>> It is a bit peculiar that the Chain command is called "Export WAV" but >>>>> the dialogue is the "Export other uncompressed formats" dialogue. >>>>> >>>>> At the moment it looks odd that Export WAV is separate from the other >>>>> Export commands, but personally I think I'd prefer the Export commands >>>>> to all be in the alphabetic list. >>>>> >>>>> Steve >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> See everything from the browser to the database with AppDynamics >>> Get end-to-end visibility with application monitoring from AppDynamics >>> Isolate bottlenecks and diagnose root cause in seconds. >>> Start your free trial of AppDynamics Pro today! >>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> audacity-devel mailing list >>> aud...@li... >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >> ------------------------------------------------------------------------------ >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> _______________________________________________ >> audacity-devel mailing list >> aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel > > > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Gale A. <ga...@au...> - 2013-07-13 18:18:38
|
| From Federico Miyara <fm...@fc...> | Thu, 11 Jul 2013 03:46:12 -0300 | Subject: [Audacity-devel] ExportWAV in batch = Effect with parameters > I tested one simple wav file 20 s long which I generated with Cool > Edit 2000 including some metadata as prompted in an "Info" menu > entry. The items available where > > Display Title > Original Artist > Name > Genre > Key Words > Digitization Source > Original Medium > Engineers > Digitizer > Source Supplier > Copyright > Software Package > Creation Date > Comments > Subject > > Audacity imported only: > > Original Artist ----> Artist Name > Name ----> Track Title > Creation Date ----> Year > Comments ----> Comments > Software Package ----> Software > Copyright ----> Copyright Expected, because CoolEdit seems to write tags in LIST and BEXT chunks. Audacity has poor support for the former and none for the latter. > I also created some cues and labels within Cool Edit, but I couldn't > import them into the Audacity Project. Audacity doesn't support CUE chunks either - worse, it removes them on export. Has anyone tried to get the old Cue/Loop Forum patch here working: http://forum.audacityteam.org/viewtopic.php?p=140743#p140743 ? Gale > In order to import labels they should be in the form of a text file, but > wav editors include that metadata at the end of the audio file, after > the audio chunk. > > >Sent from my iPhone. Bits per sample also came in correctly. So > >.wav imports with the necessary info. I would like to be able to > >add GPS coordinates and time of recordings. > > You can add them as labels, opening a label track: Menu bar / Track / > Add New / Label track. > > Then place the cursor at the instant to which you wish to associate > GPS data (or drag the cursor to cover a time interval) and then: Menu > bar / Track / Add Label At Selection > > Then write down the GPS (or whatever) data in the space provided for > that purpose > > Regards, > > Federico Miyara |
From: Federico M. <fm...@fc...> - 2013-07-14 19:13:46
|
Dear all, I think it would be relatively easy to include support for all kinds of metadata that .wav can offer both when importing and when exporting. It is easier at the import stage, since Audacity projects, having room for an arbitrary large number of label tracks, could host several categories of metadata. Recording industry metadata, such as artist, genre, copyright and so on have a special location at the tags element. Cues (labels and notes) could be retrieved and saved in two label tracks named "Labels" and "Notes". Exporting is a bit more complicated, because one could have many label tracks in an Audacity Project but only two categories in a .wav file. One way might be to use the .wav label category to host the .aup track label name and the label text itself would be rendred as note fields associated with cues. In other words, each label in whatever label track would generate a cue. Regards, Federico Miyara At 07:18 p.m. 13/07/2013 +0100, you wrote: >| From Federico Miyara <fm...@fc...> >| Thu, 11 Jul 2013 03:46:12 -0300 >| Subject: [Audacity-devel] ExportWAV in batch = Effect with parameters > > I tested one simple wav file 20 s long which I generated with Cool > > Edit 2000 including some metadata as prompted in an "Info" menu > > entry. The items available where > > > > Display Title > > Original Artist > > Name > > Genre > > Key Words > > Digitization Source > > Original Medium > > Engineers > > Digitizer > > Source Supplier > > Copyright > > Software Package > > Creation Date > > Comments > > Subject > > > > Audacity imported only: > > > > Original Artist ----> Artist Name > > Name ----> Track Title > > Creation Date ----> Year > > Comments ----> Comments > > Software Package ----> Software > > Copyright ----> Copyright > >Expected, because CoolEdit seems to write tags in LIST and BEXT >chunks. Audacity has poor support for the former and none for >the latter. > > > > I also created some cues and labels within Cool Edit, but I couldn't > > import them into the Audacity Project. > >Audacity doesn't support CUE chunks either - worse, it removes >them on export. > >Has anyone tried to get the old Cue/Loop Forum patch here working: >http://forum.audacityteam.org/viewtopic.php?p=140743#p140743 ? > > > >Gale > > > > In order to import labels they should be in the form of a text file, but > > wav editors include that metadata at the end of the audio file, after > > the audio chunk. > > > > >Sent from my iPhone. Bits per sample also came in correctly. So > > >.wav imports with the necessary info. I would like to be able to > > >add GPS coordinates and time of recordings. > > > > You can add them as labels, opening a label track: Menu bar / Track / > > Add New / Label track. > > > > Then place the cursor at the instant to which you wish to associate > > GPS data (or drag the cursor to cover a time interval) and then: Menu > > bar / Track / Add Label At Selection > > > > Then write down the GPS (or whatever) data in the space provided for > > that purpose > > > > Regards, > > > > Federico Miyara > > > >------------------------------------------------------------------------------ >See everything from the browser to the database with AppDynamics >Get end-to-end visibility with application monitoring from AppDynamics >Isolate bottlenecks and diagnose root cause in seconds. >Start your free trial of AppDynamics Pro today! >http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >_______________________________________________ >audacity-devel mailing list >aud...@li... >https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Federico M. <fm...@fc...> - 2013-07-11 17:57:11
|
Gary, >My perspective is that PCM is a generic term for 2s complement >binary coded data with any number of bits per sample. .wav is PCM >with specific metadata, header format, etc. such as track name, >sampling freq in Hz (32 bit integer), track number (16 bit integer). > >PCM is not a file format, it is an encoding method. > >AIFF is PCM with different header format. > >Btw. I just this day recorded a number of named files with 1000000Hz >sampling freq and ported the to audacity. File names came in as >track names and sample freq also displayed correctly in the track info area. I tested one simple wav file 20 s long which I generated with Cool Edit 2000 including some metadata as prompted in an "Info" menu entry. The items available where Display Title Original Artist Name Genre Key Words Digitization Source Original Medium Engineers Digitizer Source Supplier Copyright Software Package Creation Date Comments Subject Audacity imported only: Original Artist ----> Artist Name Name ----> Track Title Creation Date ----> Year Comments ----> Comments Software Package ----> Software Copyright ----> Copyright I also created some cues and labels within Cool Edit, but I couldn't import them into the Audacity Project. In order to import labels they should be in the form of a text file, but wav editors include that metadata at the end of the audio file, after the audio chunk. >Sent from my iPhone. Bits per sample also came in correctly. So >.wav imports with the necessary info. I would like to be able to >add GPS coordinates and time of recordings. You can add them as labels, opening a label track: Menu bar / Track / Add New / Label track. Then place the cursor at the instant to which you wish to associate GPS data (or drag the cursor to cover a time interval) and then: Menu bar / Track / Add Label At Selection Then write down the GPS (or whatever) data in the space provided for that purpose Regards, Federico Miyara |
From: Joel B. <bo...@ho...> - 2013-07-16 17:11:18
|
Hello, here is a patch which implements several "Exportxxx" commands in batch Chains. The parameters are specific to the encoding format. The "ExportPCM" command corresponds to the previous "ExportWAV" command. It covers all the "uncompressed" formats (WAV, AIFF, ADPCM, ...). The new "ExportWAV" and "ExportAIFF" commands are simplified subsets of the "ExportPCM" command. Here is the new command list: ExportAAC : relies on ffmpeg ExportAC3 : relies on ffmpeg ExportAIFF : relies on ExportPCM ExportFLAC : ExportMP3 : relies on "lame" ExportOGG : ExportPCM : replaces ExportWAV ExportWAV : relies on ExportPCM ExportWMA : relies on ffmpeg I also join a small patch for the "Audacity.vcproj" on Visual 2008. It is necessary to take the new files into account. Otherwise, the files: ExportAAC.cpp ExportAAC.h ExportAC3.cpp ExportAC3.h" ExportAIFF.cpp ExportAIFF.h ExportWAV.cpp ExportWAV.h ExportWMA.cpp ExportWMA.h must be manually added to the project. Thank you for your experiments and your remarks! Best regards, Joël |
From: Joel B. <bo...@ho...> - 2013-07-17 12:18:02
|
Hello, Hello, i have already noticed a bug about the new Export Commands that i have implemented: the new commands appear in the "Effect" menu but, when an "export effect" is launched the parameters entered through the dedicated dialog box are not taken into account. This problem has been easy to solve. You will find the updated patch in attachment. But i wonder if it would not be better to remove those new commands from the "effects" menu... They duplicate the already existing "File->Export" menu and might be a source of confusion. Moreover they do not offer the possibility to edit the Metadata before exporting and the export destination is always the default "../cleaned" subdirectory. By the way, even when running a command chain, not being able to choose the destination directory is quite a nuisance... especially when working on files located on a locked SD Card ;-) I think that it would be fine to be able to choose another location before launching the chain. Best regards, Joel |
From: Steve t. F. <ste...@gm...> - 2013-07-17 13:17:05
|
On 17 July 2013 13:17, Joel Bouchat <bo...@ho...> wrote: > Hello, > > Hello, > > i have already noticed a bug about the new Export Commands that i have implemented: > the new commands appear in the "Effect" menu but, when an "export effect" is launched the parameters entered through the dedicated dialog box are not taken into account. > This problem has been easy to solve. You will find the updated patch in attachment. > > But i wonder if it would not be better to remove those new commands from the "effects" menu... > They duplicate the already existing "File->Export" menu and might be a source of confusion. > Moreover they do not offer the possibility to edit the Metadata before exporting and the export destination is always the default "../cleaned" subdirectory. > > By the way, even when running a command chain, not being able to choose the destination directory is quite a nuisance... especially when working on files located on a locked SD Card ;-) > I think that it would be fine to be able to choose another location before launching the chain. Hi Joel. Sorry I've not yet had time to try your recent patches, but I agree that it would often be very useful to be able to choose another location before launching the Chain. My own use case is that much of the music that I work with is stored on a network drive. Copying files into a project is no problem, but exporting the processed files across the network is slow and annoying as I then have to move it back from the network drive to the local machine which is where I want it. Is that another feature that you'd like to work on? (I hope so :-) Steve > > Best regards, > > Joel > ------------------------------------------------------------------------------ |
From: Joel B. <bo...@ho...> - 2013-07-17 18:43:24
|
Hello Steve, thank you for your reply. There is absolutely no urgency in testing those new Export commands, this is only a possible upgrade to Audacity, not a bug fixing. I have the same problem as yourself: i use a Raspberry Pi as an "audio server" and writing files on it is extremely slow. My CPL network is fast enough, but the Raspberry Pi has no hard disk, only a 64 GB USB flash drive. For running a large batch chain, i can plug the USB key directly on the PC but this remains very slow. I will work on this problem. Also, i will try to remove those new Export commands from the "Effect Menu" (without modifying too much the menu processing). The commands will stay accessible from the "Edit Chains" and "Apply chain" as usual. The "Metadata" management remains also a priority. As other members claim, i need to keep the whole metadata and cue info when converting files to 48 kbps FLAC or PCM format. Best regards, Joel ---------------------------------------- > Date: Wed, 17 Jul 2013 14:16:57 +0100 > From: ste...@gm... > To: aud...@li... > Subject: Re: [Audacity-devel] Several "Export" commands for batch chains patch > > On 17 July 2013 13:17, Joel Bouchat <bo...@ho...> wrote: >> Hello, >> >> Hello, >> >> i have already noticed a bug about the new Export Commands that i have implemented: >> the new commands appear in the "Effect" menu but, when an "export effect" is launched the parameters entered through the dedicated dialog box are not taken into account. >> This problem has been easy to solve. You will find the updated patch in attachment. >> >> But i wonder if it would not be better to remove those new commands from the "effects" menu... >> They duplicate the already existing "File->Export" menu and might be a source of confusion. >> Moreover they do not offer the possibility to edit the Metadata before exporting and the export destination is always the default "../cleaned" subdirectory. >> >> By the way, even when running a command chain, not being able to choose the destination directory is quite a nuisance... especially when working on files located on a locked SD Card ;-) >> I think that it would be fine to be able to choose another location before launching the chain. > > Hi Joel. Sorry I've not yet had time to try your recent patches, but I > agree that it would often be very useful to be able to choose another > location before launching the Chain. > > My own use case is that much of the music that I work with is stored > on a network drive. Copying files into a project is no problem, but > exporting the processed files across the network is slow and annoying > as I then have to move it back from the network drive to the local > machine which is where I want it. > > Is that another feature that you'd like to work on? (I hope so :-) > > Steve > > >> >> Best regards, >> >> Joel >> ------------------------------------------------------------------------------ > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Gale A. <ga...@au...> - 2013-07-18 23:56:41
|
| From Joel Bouchat <bo...@ho...> | Wed, 17 Jul 2013 20:43:15 +0200 | Subject: [Audacity-devel] Several "Export" commands for batch chains patch > [...]i will try to remove those new Export commands from the "Effect Menu" > (without modifying too much the menu processing). > The commands will stay accessible from the "Edit Chains" and "Apply chain" as usual. +1. I would like to hold off testing in the hope that you can do that, then have a thorough test. Also was there a reason not to add a command for Export AMR NB? There would be a prompt to mix down to mono if the input was stereo, but the user can turn that prompt off for further occurrences. Thanks again, Gale > The "Metadata" management remains also a priority. As other members claim, > i need to keep the whole metadata and cue info when converting files to > 48 kbps FLAC or PCM format. |
From: Joel B. <bo...@ho...> - 2013-07-19 16:01:27
|
Hello Gale, here is the patch with the "Exporting xxx" removed from the Effect Menu. The "ExportAMR" command has been added to the chain commands. This one is very simple; no need for a sampling frequency selector, it is always forced to 8 ksps by the FFmpeg encoder! Also, the AMR format is always mono, therefore i have set "numChannels" to 1 when calling "mBatchCmd.mExporter.Process". Do you want that i add a "Force to Mono" option in every Export Dialog Box? Best regard, Joel ---------------------------------------- > Date: Fri, 19 Jul 2013 00:56:17 +0100 > From: ga...@au... > To: aud...@li... > Subject: Re: [Audacity-devel] Several "Export" commands for batch chains patch > > > | From Joel Bouchat <bo...@ho...> > | Wed, 17 Jul 2013 20:43:15 +0200 > | Subject: [Audacity-devel] Several "Export" commands for batch chains patch >> [...]i will try to remove those new Export commands from the "Effect Menu" >> (without modifying too much the menu processing). >> The commands will stay accessible from the "Edit Chains" and "Apply chain" as usual. > > +1. I would like to hold off testing in the hope that you can do that, > then have a thorough test. > > Also was there a reason not to add a command for Export AMR NB? > There would be a prompt to mix down to mono if the input was > stereo, but the user can turn that prompt off for further occurrences. > > > Thanks again, > > > > Gale > > > >> The "Metadata" management remains also a priority. As other members claim, >> i need to keep the whole metadata and cue info when converting files to >> 48 kbps FLAC or PCM format. > > > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Gale A. <ga...@au...> - 2013-07-20 22:59:34
|
| From Joel Bouchat <bo...@ho...> | Fri, 19 Jul 2013 18:01:18 +0200 | Subject: [Audacity-devel] Several "Export" commands for batch chains patch > here is the patch with the "Exporting xxx" removed from the Effect Menu. > > The "ExportAMR" command has been added to the chain commands. > This one is very simple; no need for a sampling frequency selector, it is > always forced to 8 ksps by the FFmpeg encoder! > Also, the AMR format is always mono, therefore i have set "numChannels" > to 1 when calling "mBatchCmd.mExporter.Process". > > Do you want that i add a "Force to Mono" option in every Export Dialog Box? Hi Joel I gave it a test run on Win 7, using the modified patch you sent me off list which fixed compiling on Windows Unicode Release (Unicode Debug compiled as per your post). As you pointed out off list, user can add a Chain command for "StereoToMono" so I don't see a need for "Force to Mono". Running an export command in the Chain now doesn't change the currently chosen options for standard export, thanks. I'm very pleased generally with the functionality, but don't like using different default parameters for Chain exports compared to straight export parameters. Details follow - others can probably skip them. There seem to be a couple of bugs. * Selecting "unchanged" in the sample rate drop-down in the parameters dialogs then choosing OK resets itself to the lowest sample rate in the list (and that rate is actually used). * "ExportWMA" saves files with WMV extension. Other points. * Don't we want an "ExportMP2" command? * Do we want an "ExportGSM 6.10WAV" command? Perhaps not, but using "ExportPCM" in a Chain to export GSM fails on a stereo track "cannot export audio". The same issue occurs if you use "Other uncompressed files" straight export to GSM (but not if you choose the "GSM 6.10 WAV (mobile)" straight export item). * Do we want 24-bit options for ExportWAV and ExportAIFF as you provide, or leave it at 16-bit only so that it matches with straight export? I'm OK with 24-bit as long as the default is 16-bit 44100 Hz. * I like the automatic change of sample rate where sample rate is incompatible with bit rate (e.g. MP3 8000 Hz 256 kbps is changed to 32000 Hz sample rate) - as long as that's documented. But should the Chain store the modified sample rate so user can see what rate is actually used? * Instead of "Bit rate" text, the dialogs have "<format> encoding bit rate" - maybe just "Bit rate"? * Why do the ExportMP3 bit rate settings differ from those in Straight export (no Presets, changed text in the drop-down, defaults to 256 kbps stereo instead of 128 kbps JS)? IIRC Steve wants to make the MP3 export default 256 kbps stereo. I feel that might create "too large" files for many, but either way shouldn't the defaults for Chains match with those for straight export? Similarly you seem to have increased default WMA bit rate and AAC quality. * I tested what happened if user came from previous Audacity to your patched version where they had an existing ExportWAV Chain command. It doesn't seem a problem, except that if they are working with other than 44100 Hz sample rate, they will get 44100 Hz export in your version instead of the rate they were expecting (and they won't see that until they press the "Edit Parameters" button). Should anything be done e.g. if the text file for the Chain has no parameters, export as "unchanged" rate and store that? Thanks, Gale > ---------------------------------------- > > Date: Fri, 19 Jul 2013 00:56:17 +0100 > > From: ga...@au... > > To: aud...@li... > > Subject: Re: [Audacity-devel] Several "Export" commands for batch chains patch > > > > > > | From Joel Bouchat <bo...@ho...> > > | Wed, 17 Jul 2013 20:43:15 +0200 > > | Subject: [Audacity-devel] Several "Export" commands for batch chains patch > >> [...]i will try to remove those new Export commands from the "Effect Menu" > >> (without modifying too much the menu processing). > >> The commands will stay accessible from the "Edit Chains" and "Apply chain" as usual. > > > > +1. I would like to hold off testing in the hope that you can do that, > > then have a thorough test. > > > > Also was there a reason not to add a command for Export AMR NB? > > There would be a prompt to mix down to mono if the input was > > stereo, but the user can turn that prompt off for further occurrences. > > > > > > Thanks again, > > > > > > > > Gale > > > > > > > >> The "Metadata" management remains also a priority. As other members claim, > >> i need to keep the whole metadata and cue info when converting files to > >> 48 kbps FLAC or PCM format. |
From: Joel B. <bo...@ho...> - 2013-07-23 15:37:55
|
Hello, Here is the updated patch following the remarks received from Gale. * Selecting "unchanged" in the sample rate drop-down in the parameters dialogs then choosing OK resets itself to the lowest sample rate in the list (and that rate is actually used). ==> Fixed. Last time, i added a check on the samplerate range and i forgot that "0" is a valid sampling value, it means "unchanged". "The best is the enemy of the good" ! * "ExportWMA" saves files with WMV extension. ==> Modified to "wma". Also modified in the original "ExportFFmpeg.cpp" code: the "file selector" was "asf","wmv"... I have replaced "wmv" with "wma". Other points. * Don't we want an "ExportMP2" command? ==> Done. * Do we want an "ExportGSM 6.10WAV" command? Perhaps not, but using "ExportPCM" in a Chain to export GSM fails on a stereo track "cannot export audio". The same issue occurs if you use "Other uncompressed files" straight export to GSM (but not if you choose the "GSM 6.10 WAV (mobile)" straight export item). ==> Done. Forced to "Mono" mode, as for the "AMR" exportation. I have added the sampling frequency selector to the "parameters". Setting the sampling rate is the only way to modify the encoded result (size & quality). Remark: the audio quality of the GSM format is so disastrous that lowering the sampling rate to a minimum value is advisable. * Do we want 24-bit options for ExportWAV and ExportAIFF as you provide, or leave it at 16-bit only so that it matches with straight export? I'm OK with 24-bit as long as the default is 16-bit 44100 Hz. ==> the default value is always 16 bit PCM in WAV, AIFF, FLAC and other modes. * I like the automatic change of sample rate where sample rate is incompatible with bit rate (e.g. MP3 8000 Hz 256 kbps is changed to 32000 Hz sample rate) - as long as that's documented. But should the Chain store the modified sample rate so user can see what rate is actually used? ==> The ExportMP3 command, and the newly implemented ExportMP2 command, now include a check in the dialog box that inhibits the "OK" button when the sample frequency don't fit the bit rate. Also, the sample frequency is displayed in the "progress" message when the chain is executed. Remark: The most awkward situation is when the bitrate is 144 kbps : the sample rate must be <= 24000 sps ! Cannot understand why! Is it a limitation of the lame encoder or is it specified in the mp3 standard? * Instead of "Bit rate" text, the dialogs have "<format> encoding bit rate" - maybe just "Bit rate"? ==> Ok, done. * Why do the ExportMP3 bit rate settings differ from those in Straight export (no Presets, changed text in the drop-down, defaults to 256 kbps stereo instead of 128 kbps JS)? IIRC Steve wants to make the MP3 export default 256 kbps stereo. I feel that might create "too large" files for many, but either way shouldn't the defaults for Chains match with those for straight export? Similarly you seem to have increased default WMA bit rate and AAC quality. ==> Ok, i have cancelled the discrepancies. Here are the default values used: mp3: constant 128k Joint Stereo ogg: quality 5 flac: level 5 16 bits mp2 160 kbps AAC quality 100 AC3 160 kbps AMR 12.2 kbps WMA 96 kbps WAV 16 bits AIFF 16 bits BUT, i totally agree with Steve, 128 kbps belongs to the past, when mp3 players had 128 M.O. of Flash memory! The present trend is to use 320 KBPS or 256KBPS VBR, (Amazon, Sony Music, ...). Listening to music encoded at 128kbps is some kind of masochism, especially in Joint Stereo with a headphone! Maybe we could add a warning message: "WARNING: By selecting this encoding format, you might severely impair your musical meaning. You are also insulting the artists and the sound engineers who created this masterpiece!" ;-). I also noticed that when encoding in MP2, MP3, and WMA formats at low bit rates, (<=160 kbps), a sampling frequency of 32 kbps gives better results than 44.1 kbps or 48 kbps, but Joint Stereo must NEVER be used with a lossy encoding scheme. * I tested what happened if user came from previous Audacity to your patched version where they had an existing ExportWAV Chain command. It doesn't seem a problem, except that if they are working with other than 44100 Hz sample rate, they will get 44100 Hz export in your version instead of the rate they were expecting (and they won't see that until they press the "Edit Parameters" button). Should anything be done e.g. if the text file for the Chain has no parameters, export as "unchanged" rate and store that? ==> Done. A very simple solution using a flag in the project class. This flag states that the command holds no parameter. So straightforward that it took me several hours to find how to implement it! Same problem as Vaughan for the "Bug 307" on tooltips: the "GetActiveProject()" returned NULL. After having implemented a method to force the "shuttle" to transmit the "lack of parameter" to the useless "EffectExportXXX" class, where the Active project is finaly instanciated, i have discovered that the project had already been instanciated much before, inside the generic "Export" class... Still wonder how this instance could be lost. How happy were people working in "Plain Old C"! Now, when no parameters are present, the chain Export commands use the parameters of the last straight Export performed, or the default values. The sampling rate is the value saved in the preferences. Best regards, Joel |
From: Gale A. <ga...@au...> - 2013-07-30 01:15:34
|
| From Joel Bouchat <bo...@ho...> | Tue, 23 Jul 2013 17:37:46 +0200 | Subject: [Audacity-devel] Several "Export" commands for batch chains patch > Here is the updated patch following the remarks received from Gale. Thanks for your efforts, Joel. Sorry I have not been able to test it until now. First off, a bug has got in there at some stage. Some of the effects open the Chain export dialogues e.g. * Normalize opens Export GSM * Noise Removal opens Export FLAC * Repeat opens Export WAV and some items open the wrong effects (Truncate Silence does Invert). MP2/MP3 and the greying out of OK seem to have problems, as detailed below. > * Selecting "unchanged" in the sample rate drop-down in the > parameters dialogs then choosing OK resets itself to the > lowest sample rate in the list (and that rate is actually used). > ==> Fixed. Last time, i added a check on the samplerate range and i > forgot that "0" is a valid sampling value, it means "unchanged". "The > best is the enemy of the good" ! OK, thanks. > * "ExportWMA" saves files with WMV extension. > ==> Modified to "wma". OK, that works now. > Also modified in the original "ExportFFmpeg.cpp" code: the "file selector" was "asf","wmv"... > I have replaced "wmv" with "wma". OK, it's fair enough to warn if you try to export as WMV, thanks. > * Don't we want an "ExportMP2" command? > ==> Done. Something is not quite correct for this one. 48000 Hz 56 kbps MP2 is valid, and works if you select the sample rate explicitly in the dialogue. But if you choose "unchanged" with a project rate of 48000 Hz, 56 kbps export fails with "cannot export with this sample rate and bit rate". > * Do we want an "ExportGSM 6.10WAV" command? Perhaps not, but > using "ExportPCM" in a Chain to export GSM fails on a stereo track > "cannot export audio". The same issue occurs if you use "Other > uncompressed files" straight export to GSM (but not if you choose > the "GSM 6.10 WAV (mobile)" straight export item). > ==> Done. Forced to "Mono" mode, as for the "AMR" exportation. > I have added the sampling frequency selector to the "parameters". > Setting the sampling rate is the only way to modify the encoded result > (size & quality). Thanks. Should the rates in the dialogue go up to 384000 since those are valid (notwithstanding any quality issues)? Do you think you could also force to mono when exporting to GSM via Export PCM (Chain) and "Other uncompressed files" (straight export)? > * I like the automatic change of sample rate where sample rate is > incompatible with bit rate (e.g. MP3 8000 Hz 256 kbps is changed > to 32000 Hz sample rate) - as long as that's documented. > But should the Chain store the modified sample rate so user can > see what rate is actually used? > ==> The ExportMP3 command, and the newly implemented ExportMP2 > command, now include a check in the dialog box that inhibits the "OK" > button when the sample frequency don't fit the bit rate. Does anyone have views if we should show brief explanatory text when the OK button is greyed? See Truncate Silence for an example. I think it may be a good idea, because the problem may not be obvious if sample rate is "unchanged" but the project rate is too high. There seem to be two problems with MP3 export: * Some valid CBR sample rate/bit rate combinations e.g. 48000 Hz / 56 kbps cause OK to grey out, either if chosen explicitly or if you choose "unchanged" with project rate on 48000 Hz. But if you change to VBR, OK ungreys. * Some combinations don't export the indicated bit rate e.g. 8000 Hz / 128 kbps CBR when exporting from a mono or stereo track produces a 64 kbps file. Also for FFmpeg formats (I tested WMA and AC3), if you choose "unchanged" and the project rate is too high, no greying out or silent correction occurs. So if the project rate is e.g. 384000 Hz the Chain produces a zero bytes file. > Also, the sample frequency is displayed in the "progress" message when > the chain is executed. I see sample rate and bit rate are included in the progress dialogue for straight MP3/MP2 export too. That's OK by me. If it's OK by others, should we do the same for: * for all compressed formats where there may be sample rate/bit rate conflicts * all compressed formats that use bit rate * or for all compressed formats (including those that have a quality rather than bit rate parameter)? I'm OK with doing it for all compressed formats. > Remark: The most awkward situation is when the bitrate is 144 kbps : > the sample rate must be <= 24000 sps ! Cannot understand why! Is it a > limitation of the lame encoder or is it specified in the mp3 standard? I agree it's odd given that 128 kbps @ 44100 Hz is accepted, but that is the standard: http://wiki.audacityteam.org/wiki/Lame_Installation#valid . > * Why do the ExportMP3 bit rate settings differ from those in > Straight export (no Presets, changed text in the drop-down, > defaults to 256 kbps stereo instead of 128 kbps JS)? > > IIRC Steve wants to make the MP3 export default 256 kbps > stereo. I feel that might create "too large" files for many, but > either way shouldn't the defaults for Chains match with those > for straight export? Similarly you seem to have increased > default WMA bit rate and AAC quality. > ==> Ok, i have cancelled the discrepancies. Here are the default values used: > > mp3: constant 128k Joint Stereo > ogg: quality 5 > flac: level 5 16 bits > mp2 160 kbps > AAC quality 100 > AC3 160 kbps > AMR 12.2 kbps > WMA 96 kbps > WAV 16 bits > AIFF 16 bits > > BUT, i totally agree with Steve, 128 kbps belongs to the past, when mp3 > players had 128 M.O. of Flash memory! > The present trend is to use 320 KBPS or 256KBPS VBR, (Amazon, Sony Music, ...). > Listening to music encoded at 128kbps is some kind of masochism, especially > in Joint Stereo with a headphone! I guess I could ask for votes on the -quality list if we want to review this. There are concerns for huge files like audio books, and people uploading to web sites. > * I tested what happened if user came from previous Audacity to > your patched version where they had an existing ExportWAV > Chain command. > > It doesn't seem a problem, except that if they are working with > other than 44100 Hz sample rate, they will get 44100 Hz export > in your version instead of the rate they were expecting (and they > won't see that until they press the "Edit Parameters" button). > > Should anything be done e.g. if the text file for the Chain has no > parameters, export as "unchanged" rate and store that? > ==> Done. A very simple solution using a flag in the project class. > This flag states that the command holds no parameter. [...] > Now, when no parameters are present, the chain Export commands > use the parameters of the last straight Export performed, or the default > values. The sampling rate is the value saved in the preferences. Thanks. If there are no parameters in the ExportWAV chain, the chain export seems to use the current project rate (as switched to by file import when appropriate). So I think that's fine. Thanks again for your efforts. Gale |