From: SourceForge.net <no...@so...> - 2010-05-31 21:26:12
|
Patches item #2996824, was opened at 2010-05-04 23:26 Message generated for change (Comment added) made by kymara You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301111&aid=2996824&group_id=1111 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: oslsachem (oslsachem) >Assigned to: Katie Russell (kymara) Summary: fixes bug 2821587 Initial Comment: Suggested attempt at fixing the bug. Please review carefully. :) ---------------------------------------------------------------------- >Comment By: Katie Russell (kymara) Date: 2010-05-31 22:26 Message: Ok, I tried 3 more times and a full version did finally download! Thanks for submitting this patch. Applied with some changes: Your email address validator did not accept some valid email address like those with a ö so I used the existing simpler one checking for an @, a . and a length We don't want to fill the email address field with spam, either. So I removed that 'No Email' input into the text field, and removed the validators server side which force content of min length 6 ---------------------------------------------------------------------- Comment By: Katie Russell (kymara) Date: 2010-05-31 21:52 Message: I'm a bit confused. The file is cut off at line 110. The original file is a lot longer. Sorry but I can't do anything with this. A diff (cvs diff -uN) would be a lot better, but failing that please merge your changes with any others on CVS head and then resubmit. Thank you. http://stendhalgame.org/wiki/How_To_Create_Patch_For_Stendhal ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301111&aid=2996824&group_id=1111 |