[Arianne-bugs] [ arianne-Bugs-1980907 ] String "title" longer than 255 chars

[SourceForge.net <no...@so...>]

Bugs item #1980907, was opened at 2008-05-31 23:06
Message generated for change (Settings changed) made by arianne_rpg
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101111&aid=1980907&group_id=1111

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Bluelads4 (bluelads4)
Assigned to: Miguel Angel Blanch Lardin (arianne_rpg)
Summary: String "title" longer than 255 chars

Initial Comment:
Players will not be stored to database during a client crash! (found out by Hendrik)




----------------------------------------------------------------------

>Comment By: Miguel Angel Blanch Lardin (arianne_rpg)
Date: 2008-06-07 00:51

Message:
Logged In: YES 
user_id=3949
Originator: NO

No, it is a feature.
In fact the game should check it.

One option could be that for every attribute we check against defined type
to see if it is correct but I think it will be too CPU time consuming.
In general I think it is a good ( great ) idea to check everything players
write and limit sizes of it specially if it is to be stored at database. (
names, descriptions, chat texts, etc... )

Anyway guido deserves whatever happened to his/her player. :)


----------------------------------------------------------------------

Comment By: Astrid Sawatzky (astridemma)
Date: 2008-06-06 22:32

Message:
Logged In: YES 
user_id=964999
Originator: NO

please check if there is measure to be taken on marauroa side.

the stendhal side has been hopefully fixed, by reducing the maximum length
of naming a pet to 20.
 regards astrid

----------------------------------------------------------------------

Comment By: Hendrik (nhnb)
Date: 2008-06-03 23:24

Message:
Logged In: YES 
user_id=990499
Originator: NO

2008-05-31 22:20:17 WARN  [verManager] Definition               ( 203) -
Exception caused by name=title type=STRING code?18
value=|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
java.io.IOException: Array too large for write255LongArray.
        at
marauroa.common.net.OutputSerializer.write255LongArray(OutputSerializer.java:85)
        at
marauroa.common.net.OutputSerializer.write255LongString(OutputSerializer.java:190)
        at marauroa.common.game.Definition.serialize(Definition.java:452)
        at
marauroa.common.game.Attributes.writeObject(Attributes.java:485)
        at marauroa.common.game.RPObject.writeObject(RPObject.java:711)
        at marauroa.common.game.RPSlot.writeObject(RPSlot.java:451)
        at marauroa.common.game.RPObject.writeObject(RPObject.java:744)
        at
marauroa.server.game.db.JDBCDatabase.storeRPObject(JDBCDatabase.java:1187)
        at
marauroa.server.game.db.JDBCDatabase.storeCharacter(JDBCDatabase.java:667)
        at
games.stendhal.server.core.engine.StendhalPlayerDatabase.storeCharacter(StendhalPlayerDatabase.java:138)
        at
marauroa.server.game.container.PlayerEntry.storeRPObject(PlayerEntry.java:320)
        at
marauroa.server.game.GameServerManager.processLogoutEvent(GameServerManager.java:685)
        at
marauroa.server.game.GameServerManager.run(GameServerManager.java:432)
2008-05-31 22:20:17 WARN  [verManager] JDBCDatabase             ( 203) -
Error while serializing rpobject: Player [guido, 98712326]
java.io.IOException: Array too large for write255LongArray.
        at
marauroa.common.net.OutputSerializer.write255LongArray(OutputSerializer.java:85)
        at
marauroa.common.net.OutputSerializer.write255LongString(OutputSerializer.java:190)
        at marauroa.common.game.Definition.serialize(Definition.java:452)
        at
marauroa.common.game.Attributes.writeObject(Attributes.java:485)
        at marauroa.common.game.RPObject.writeObject(RPObject.java:711)
        at marauroa.common.game.RPSlot.writeObject(RPSlot.java:451)
        at marauroa.common.game.RPObject.writeObject(RPObject.java:744)
        at
marauroa.server.game.db.JDBCDatabase.storeRPObject(JDBCDatabase.java:1187)
        at
marauroa.server.game.db.JDBCDatabase.storeCharacter(JDBCDatabase.java:667)
        at
games.stendhal.server.core.engine.StendhalPlayerDatabase.storeCharacter(StendhalPlayerDatabase.java:138)
        at
marauroa.server.game.container.PlayerEntry.storeRPObject(PlayerEntry.java:320)
        at
marauroa.server.game.GameServerManager.processLogoutEvent(GameServerManager.java:685)
        at
marauroa.server.game.GameServerManager.run(GameServerManager.java:432)
2008-05-31 22:20:17 WARN  [verManager] JDBCDatabase             ( 203) -
Error storing character: Player [guido, 98712326]
java.io.IOException: Array too large for write255LongArray.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101111&aid=1980907&group_id=1111