From: SourceForge.net <no...@so...> - 2005-07-14 18:56:53
|
Bugs item #1200524, was opened at 2005-05-12 13:29 Message generated for change (Comment added) made by mtotz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=1200524&group_id=1111 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 8 Submitted By: Miguel Angel Blanch Lardin (arianne_rpg) Assigned to: Matthias Totz (mtotz) Summary: Marauroa: Improve logging output Initial Comment: Make it more informative, make sure that important variables values that can help to understand and trace the code are displayed. ---------------------------------------------------------------------- >Comment By: Matthias Totz (mtotz) Date: 2005-07-14 20:56 Message: Logged In: YES user_id=1127086 updated package marauroa.server package marauroa.server.net class marauroa.server.game.GameServerManager In some cases I removed the try-finally constucts (these are not necessary and bad for performance anyway) Please review these changes as especially GameServerManager is a crucial part (I have tested them of course, seems still to work). ---------------------------------------------------------------------- Comment By: Matthias Totz (mtotz) Date: 2005-07-13 23:03 Message: Logged In: YES user_id=1127086 About printing the method: Yes, it is possible. But most times it is not *neccesary*. The most important part of logging are the stacktraces in case of an error. In the other files I prepared the method will be written as a message so it it simply an implementation detail. In the log files nothing changes. ---------------------------------------------------------------------- Comment By: Miguel Angel Blanch Lardin (arianne_rpg) Date: 2005-07-13 22:46 Message: Logged In: YES user_id=3949 BTW I dunno if log4j will handle it automatically, but it would be a nice thing to print also the method from where the logger.thing was called. ( as it is now. ) ---------------------------------------------------------------------- Comment By: Miguel Angel Blanch Lardin (arianne_rpg) Date: 2005-07-13 22:44 Message: Logged In: YES user_id=3949 don't worry. I trust your work, replace at will. Also when you are done remove the old logging system, so everyone is "forced" to use the new one. ---------------------------------------------------------------------- Comment By: Matthias Totz (mtotz) Date: 2005-07-13 22:32 Message: Logged In: YES user_id=1127086 Added a first test to cvs. The main class 'marauroad' now logs to log4j, all other stuff logs with the old logger. If this works without problems I commit some more changes (module marauroa only) Note: The logger is configured (in marauroa/log4j.properties) to past all stuff with a priority warn and higher to the console, but all stuff will be written to a log-file, 'server' is the current one, it'll be rotated by midnight. This file is readable with LogFactor5. Line 11 in log4j.properties will create a LogFactor5 swing window showing all logging events (great for debugging but not so cool for a deamon so it is disabled by default) ---------------------------------------------------------------------- Comment By: Matthias Totz (mtotz) Date: 2005-07-11 21:08 Message: Logged In: YES user_id=1127086 logging will be ported to log4j. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=1200524&group_id=1111 |