Re: [Aqsis-development] Bug fixes for aqsis-1.4.1

[Chris F. <fo...@ph...>]

On Mon, Sep 15, 2008 at 02:02:29PM +0100, Paul Gregory wrote:
> I've started the merge. Detailed below are the merged changes from this
> list, any issues, and some modifications and additions. Most notable from
> the list are 2348, which modified ienvironmentsampler.h and
> cubeenvironmentsampler.h, both of which are in the new environment handling
> code. Also 2390 and 2442 are reliant on the CqAttributes reference counting
> change, hence they are listed under the three changes that affected that,
> 2380,2381 and 2382. All the ones below that have a ? by them are to be
> reviewed, I'd appreciate it if the original committers could comment here.
> 
> 
> #2339 - Done/RTS/Commit #2451
> #2341 - Done/RTS/Commit #2452
> ?2342
> ?2344
> ?2345

This seems like an important and useful fix to me.  I think it's worth
including.

> *2348 - This one seems to be reliant on the new environment mapping code.

Oops, you're quite right.  This one should be ignored as it's not
relevant to the aqsis-1.4 branch.

> #2359 - Done/RTS/Commit #2453
> #2376,2384 - Done/RTS/Commit #2454
> #2377 - Done/RTS/Commit #2455
> ?2380,2381,2382,2390,2442

2442 is independent of the rest of these - the shared_ptr touched by
this bug fix was already in use before the attribute pointer refactor.

As to 2380,2381,2382,2390; these represent a rather large patch which
is a bit of a negative.  Other than that I think it's worth merging
them but I don't have a clear yes/no opinion here.

> #2385 - Done/RTS/Commit #2456
> #2386 - Done/RTS/Commit #2457
> #2387,2391 - Done/RTS/Commit #2458
> #2388 - Done/RTS/Commit #2459
> #2389 - Done/RTS/Commit #2460
> ?2439
> #2443 - Done/RTS/Commit #2461
> ?2444

I think 2444 isn't relevant?  CqPrimvarToken was only introduced with
the new RIB parser.

> ?2445

---------------------

Finally, I'd like to add Michel's change 2392 to the list.  IIRC it
fixes a bug where piqsl would crash on null file names.

Cheers,
~Chris.